Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow error layouts to be added through addLayout #3834

Merged
merged 6 commits into from
Sep 2, 2018

Conversation

manniL
Copy link
Member

@manniL manniL commented Sep 1, 2018

Resolves: #3194

@manniL manniL force-pushed the feat-let-add-layout-add-error-layout branch from 353f269 to 407e11f Compare September 1, 2018 23:55
@manniL manniL force-pushed the feat-let-add-layout-add-error-layout branch from 407e11f to d0c8de1 Compare September 2, 2018 00:02
@manniL manniL requested review from clarkdo and pi0 September 2, 2018 00:08
@manniL manniL force-pushed the feat-let-add-layout-add-error-layout branch from 3bf825a to 6d29f67 Compare September 2, 2018 00:12
@codecov-io
Copy link

codecov-io commented Sep 2, 2018

Codecov Report

Merging #3834 into dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #3834      +/-   ##
==========================================
+ Coverage   97.84%   97.85%   +<.01%     
==========================================
  Files          18       18              
  Lines        1162     1164       +2     
  Branches      317      318       +1     
==========================================
+ Hits         1137     1139       +2     
  Misses         24       24              
  Partials        1        1
Impacted Files Coverage Δ
lib/core/module.js 100% <100%> (ø) ⬆️
lib/builder/builder.js 96.31% <100%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f6a048...c7ff120. Read the comment docs.

@manniL manniL force-pushed the feat-let-add-layout-add-error-layout branch from 6d29f67 to d1cf63c Compare September 2, 2018 00:34
@manniL manniL added WIP and removed WIP labels Sep 2, 2018
@manniL manniL force-pushed the feat-let-add-layout-add-error-layout branch from 3d37bef to da8b3e4 Compare September 2, 2018 01:49
@manniL manniL force-pushed the feat-let-add-layout-add-error-layout branch from da8b3e4 to f0210e0 Compare September 2, 2018 01:52
Copy link

@galvez galvez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lib/core/module.js Show resolved Hide resolved
@pi0 pi0 merged commit 6e8a515 into nuxt:dev Sep 2, 2018
@manniL manniL deleted the feat-let-add-layout-add-error-layout branch September 2, 2018 10:24
@willin
Copy link
Contributor

willin commented Sep 25, 2018

@manniL thx for your efforts.

i notice that this pr not has documentations included.

@manniL
Copy link
Member Author

manniL commented Sep 25, 2018

@willin Thanks for you feedback. In general the docs for the module functions (like addLayout) are missing. We will add them shortly.

@lock
Copy link

lock bot commented Oct 31, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

this.addLayout of module not possible to set error layout
6 participants