feat: allow error layouts to be added through addLayout #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
353f269
to
407e11f
Compare
407e11f
to
d0c8de1
Compare
3bf825a
to
6d29f67
Compare
Codecov Report
@@ Coverage Diff @@
## dev #3834 +/- ##
==========================================
+ Coverage 97.84% 97.85% +<.01%
==========================================
Files 18 18
Lines 1162 1164 +2
Branches 317 318 +1
==========================================
+ Hits 1137 1139 +2
Misses 24 24
Partials 1 1
Continue to review full report at Codecov.
|
6d29f67
to
d1cf63c
Compare
3d37bef
to
da8b3e4
Compare
da8b3e4
to
f0210e0
Compare
pi0
reviewed
Sep 2, 2018
pi0
approved these changes
Sep 2, 2018
|
@manniL thx for your efforts. i notice that this pr not has documentations included. |
|
@willin Thanks for you feedback. In general the docs for the module functions (like |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3194