Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this.addLayout of module not possible to set error layout #3194

Closed
dohomi opened this issue Apr 5, 2018 · 2 comments · Fixed by #3834
Closed

this.addLayout of module not possible to set error layout #3194

dohomi opened this issue Apr 5, 2018 · 2 comments · Fixed by #3834
Assignees
@galvez
Labels
2.x enhancement

Comments

@dohomi
Copy link

dohomi commented Apr 5, 2018

What problem does this feature solve?

Currently only layouts/error.vue is able to overwrite the error layout. I'd like to do this inside of a module with:

this.addLayout({
 name:"error",
 src: "path/to/custom/error.vue"
})

It would be helpful for module to developer to overwrite the error page on demand.

This feature request is available on Nuxt.js community (#c6850)
@ghost ghost added the cmty:feature-request label Apr 5, 2018
@galvez galvez self-assigned this Aug 29, 2018
@manniL manniL mentioned this issue Sep 1, 2018
Merged
@pi0 pi0 closed this as completed in #3834 Sep 2, 2018
pi0 pushed a commit that referenced this issue Sep 2, 2018
@manniL @pi0
feat(builder, module): allow error layouts to be added through addLay…
6e8a515 
…out. closes #3194. (#3834)
@ghost
Copy link

ghost commented Sep 2, 2018

This feature-request has been implemented by @manniL, @pi0.

@lock
Copy link

lock bot commented Oct 31, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@galvez galvez

Labels
2.x enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: allow error layouts to be added through addLayout manniL/nuxt.js
3 participants
@galvez @dohomi @danielroe