drivers: serial: rpi_pico: Migrate to pl011 driver #71074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8a207c8
to
02185d6
Compare
… code Introduce the `COMPAT_SPECIFIC_...` macros to determine the function name from the compatible name. These macros allow the isolation of device-dependent code in a generic way. For example, if the compatible name is `ambiq,uart`, The `COMPAT_SPECIFIC_DEFINE` macro is replaced by `AMBIQ_UART_DEFINE`. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Reset the device on initializing if the node inherits `reset-device.yaml`. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
If a clock control device is set in the `clocks` property, it is used to determine the frequency. If `fixed-clock` is set for the clocks, we use that value as is. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Implementing err_check function by porting from rpi_pico implementation. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
RaspberryPi Pico's UART can be operated with the pl011 driver. Replace it with this. Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
dcpleung
approved these changes
Apr 8, 2024
|
@yonsch May I have your opinion? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serial device of rpi_pico is pl011.
Since there is already a driver for pl011, the uart_rpi_pico driver is a duplicate implementation.
Considering long-term maintenance, it is better to unify them.