lint: Lint test/

victorsaly · Oct 31, 2017 · b132dec · b132dec
1 parent b214972
commit b132dec
Show file tree

Hide file tree

Showing 39 changed files with 72 additions and 71 deletions.
diff --git a/package.json b/package.json
@@ -49,7 +49,7 @@
   "scripts": {
     "test": "npm run lint && cross-env NODE_ENV=test npm run build:nuxt && nyc ava --verbose --serial test/ -- && nyc report --reporter=html",
     "coverage": "nyc report --reporter=text-lcov > coverage.lcov && codecov",
-    "lint": "eslint --ext .js,.vue bin/** lib/** test/*.js --ignore-pattern app",
+    "lint": "eslint --ext .js,.vue bin/** lib/** test/** --ignore-pattern app --ignore-pattern node_modules --ignore-pattern dist/",
     "build": "rimraf dist/ && npm run build:nuxt && npm run build:core",
     "build:nuxt": "rollup -c build/rollup.config.js --environment TARGET:nuxt",
     "build:core": "rollup -c build/rollup.config.js --environment TARGET:core",

diff --git a/test/fixtures/basic/pages/async-data.vue b/test/fixtures/basic/pages/async-data.vue
@@ -4,7 +4,7 @@
 
 <script>
 export default {
-  asyncData () {
+  asyncData() {
     return new Promise((resolve) => {
       setTimeout(() => resolve({ name: 'Nuxt.js' }), 10)
     })

diff --git a/test/fixtures/basic/pages/await-async-data.vue b/test/fixtures/basic/pages/await-async-data.vue
@@ -10,8 +10,9 @@ const fetchData = () => {
 }
 
 export default {
-  async asyncData () {
-    return await fetchData()
+  async asyncData() {
+    const data = await fetchData()
+    return data
   }
 }
 </script>
diff --git a/test/fixtures/basic/pages/callback-async-data.vue b/test/fixtures/basic/pages/callback-async-data.vue
@@ -4,7 +4,7 @@
 
 <script>
 export default {
-  async asyncData (context, callback) {
+  async asyncData(context, callback) {
     setTimeout(function () {
       callback(null, { name: 'Callback Nuxt.js' })
     }, 10)

diff --git a/test/fixtures/basic/pages/error.vue b/test/fixtures/basic/pages/error.vue
@@ -4,7 +4,7 @@
 
 <script>
 export default {
-  asyncData ({ req }) {
+  asyncData({ req }) {
     // Not for nuxt generate
     if (req) {
       throw new Error('Error mouahahah')

diff --git a/test/fixtures/basic/pages/error2.vue b/test/fixtures/basic/pages/error2.vue
@@ -4,7 +4,7 @@
 
 <script>
 export default {
-  asyncData ({ error }) {
+  asyncData({ error }) {
     error({ message: 'Custom error' })
   }
 }

diff --git a/test/fixtures/basic/pages/redirect.vue b/test/fixtures/basic/pages/redirect.vue
@@ -4,7 +4,7 @@
 
 <script>
 export default {
-  fetch ({ redirect }) {
+  fetch({ redirect }) {
     return redirect('/')
   }
 }

diff --git a/test/fixtures/basic/pages/redirect2.vue b/test/fixtures/basic/pages/redirect2.vue
@@ -3,7 +3,7 @@
 <script>
 export default {
   middleware: 'redirect',
-  created () {
+  created() {
     throw new Error('NOPE!')
   }
 }

diff --git a/test/fixtures/basic/pages/special-state.vue b/test/fixtures/basic/pages/special-state.vue
@@ -4,7 +4,7 @@
 
 <script>
 export default {
-  fetch ({ beforeNuxtRender }) {
+  fetch({ beforeNuxtRender }) {
     if (process.server) {
       beforeNuxtRender(({ nuxtState }) => {
         nuxtState.test = true

diff --git a/test/fixtures/basic/pages/stateful.vue b/test/fixtures/basic/pages/stateful.vue
@@ -6,10 +6,10 @@
 
 <script>
 export default {
-  data () {
+  data() {
     return { answer: null }
   },
-  created () {
+  created() {
     this.answer = 42
   }
 }

diff --git a/test/fixtures/basic/pages/users/_id.vue b/test/fixtures/basic/pages/users/_id.vue
@@ -4,7 +4,7 @@
 
 <script>
 export default {
-  asyncData ({ params, payload }) {
+  asyncData({ params, payload }) {
     if (payload) return payload
     return { id: params.id }
   }

diff --git a/test/fixtures/basic/pages/validate.vue b/test/fixtures/basic/pages/validate.vue
@@ -4,7 +4,7 @@
 
 <script>
 export default {
-  validate ({ query }) {
+  validate({ query }) {
     return Boolean(query.valid)
   }
 }

diff --git a/test/fixtures/basic/store/foo/bar.js b/test/fixtures/basic/store/foo/bar.js
@@ -3,7 +3,7 @@ export const state = () => ({
 })
 
 export const getters = {
-  baz (state) {
+  baz(state) {
     return state.baz
   }
 }
diff --git a/test/fixtures/basic/store/index.js b/test/fixtures/basic/store/index.js
@@ -3,7 +3,7 @@ export const state = () => ({
 })
 
 export const mutations = {
-  increment (state) {
+  increment(state) {
     state.counter++
   }
 }
diff --git a/test/fixtures/children/pages/parent.vue b/test/fixtures/children/pages/parent.vue
@@ -8,16 +8,16 @@
 <script>
 export default {
   async asyncData({ route }) {
-    const asyncData = {};
+    const asyncData = {}
 
     await new Promise((resolve, reject) => {
       setTimeout(() => {
         asyncData.name = 'parent'
-        resolve();
+        resolve()
       }, 100)
-    });
+    })
 
-    return asyncData;
+    return asyncData
   }
 }
 </script>
diff --git a/test/fixtures/children/pages/parent/_id.vue b/test/fixtures/children/pages/parent/_id.vue
@@ -5,16 +5,16 @@
 <script>
 export default {
   async asyncData({ route }) {
-    const asyncData = {};
+    const asyncData = {}
 
     await new Promise((resolve, reject) => {
       setTimeout(() => {
-        asyncData.id = route.params.id;
-        resolve();
+        asyncData.id = route.params.id
+        resolve()
       }, 50)
-    });
+    })
 
-    return asyncData;
+    return asyncData
   }
 }
 </script>
diff --git a/test/fixtures/children/pages/parent/validate-child.vue b/test/fixtures/children/pages/parent/validate-child.vue
@@ -4,7 +4,7 @@
 
 <script>
 export default {
-  validate ({ query }) {
+  validate({ query }) {
     return query.key === '12345'
   }
 }

diff --git a/test/fixtures/debug/pages/error.vue b/test/fixtures/debug/pages/error.vue
@@ -5,7 +5,7 @@
 <script>
 /* eslint no-undef: 0 */
 export default {
-  data () {
+  data() {
     throw new Error('test youch !')
   }
 }

diff --git a/test/fixtures/module/modules/basic/index.js b/test/fixtures/module/modules/basic/index.js
@@ -1,6 +1,6 @@
 const path = require('path')
 
-module.exports = function basicModule (options, resolve) {
+module.exports = function basicModule(options, resolve) {
   // Add  vendor
   this.addVendor('lodash')
 

diff --git a/test/fixtures/module/modules/basic/reverse.js b/test/fixtures/module/modules/basic/reverse.js
@@ -2,7 +2,7 @@
 
 import Vue from 'vue'
 
-function $reverseStr (str) {
+function $reverseStr(str) {
   return str.split('').reverse().join('')
 }
 

diff --git a/test/fixtures/module/modules/empty/index.js b/test/fixtures/module/modules/empty/index.js
@@ -1,4 +1,4 @@
-module.exports = function middlewareModule (options) {
+module.exports = function middlewareModule(options) {
   // Empty module
 }
 

diff --git a/test/fixtures/module/modules/middleware/index.js b/test/fixtures/module/modules/middleware/index.js
@@ -1,9 +1,9 @@
-module.exports = function middlewareModule (options) {
+module.exports = function middlewareModule(options) {
   return new Promise((resolve, reject) => {
     // Add /api endpoint
     this.addServerMiddleware({
       path: '/api',
-      handler (req, res, next) {
+      handler(req, res, next) {
         res.end('It works!')
       }
     })

diff --git a/test/fixtures/module/router.js b/test/fixtures/module/router.js
@@ -6,7 +6,7 @@ Vue.use(Router)
 const indexPage = () => import('~/views/index.vue').then(m => m.default || m)
 const aboutPage = () => import('~/views/about.vue').then(m => m.default || m)
 
-export function createRouter () {
+export function createRouter() {
   return new Router({
     mode: 'history',
     routes: [

diff --git a/test/fixtures/spa/pages/custom.vue b/test/fixtures/spa/pages/custom.vue
@@ -5,9 +5,9 @@
 <script>
 export default {
   layout: 'custom',
-  mounted () {
+  mounted() {
     window.customMounted = (+window.customMounted) + 1
-    console.log('mounted')
+    console.log('mounted') // eslint-disable-line no-console
   }
 }
-</script>
+</script>
diff --git a/test/fixtures/spa/pages/index.vue b/test/fixtures/spa/pages/index.vue
@@ -4,9 +4,9 @@
 
 <script>
 export default {
-  mounted () {
+  mounted() {
     window.indexMounted = (+window.indexMounted) + 1
-    console.log('mounted')
+    console.log('mounted') // eslint-disable-line no-console
   }
 }
-</script>
+</script>
diff --git a/test/fixtures/ssr/components/test.vue b/test/fixtures/ssr/components/test.vue
@@ -8,10 +8,10 @@
 import { nextId } from '@/lib/db'
 
 export default {
-    data() {
-        return {
-            id: nextId()
-        }
+  data() {
+    return {
+      id: nextId()
     }
+  }
 }
 </script>
diff --git a/test/fixtures/ssr/pages/asyncComponent.vue b/test/fixtures/ssr/pages/asyncComponent.vue
@@ -8,7 +8,7 @@
 const AsyncTest = () => import('@/components/test.vue').then((m) => m.default || m)
 
 export default {
-  components:{
+  components: {
     AsyncTest
   }
 }

diff --git a/test/fixtures/ssr/pages/asyncData.vue b/test/fixtures/ssr/pages/asyncData.vue
@@ -6,10 +6,10 @@
 import { nextId } from '@/lib/db'
 
 export default {
-    async asyncData() {
-        return {
-            id: nextId()
-        }
+  async asyncData() {
+    return {
+      id: nextId()
     }
+  }
 }
 </script>
diff --git a/test/fixtures/ssr/pages/component.vue b/test/fixtures/ssr/pages/component.vue
@@ -8,8 +8,8 @@
 import test from '@/components/test'
 
 export default {
-    components : {
-        test
-    }
+  components: {
+    test
+  }
 }
 </script>
diff --git a/test/fixtures/ssr/pages/data.vue b/test/fixtures/ssr/pages/data.vue
@@ -6,10 +6,10 @@
 import { nextId } from '@/lib/db'
 
 export default {
-    data() {
-        return {
-            id: nextId()
-        }
+  data() {
+    return {
+      id: nextId()
     }
+  }
 }
 </script>
diff --git a/test/fixtures/ssr/pages/fetch.vue b/test/fixtures/ssr/pages/fetch.vue
@@ -6,9 +6,9 @@
 import { nextId } from '@/lib/db'
 
 export default {
-    async fetch({store}) {
-        // We use store just as a shared reference
-        store.__id = nextId()
-    },
+  async fetch({store}) {
+    // We use store just as a shared reference
+    store.__id = nextId()
+  }
 }
 </script>
diff --git a/test/fixtures/ssr/store/index.js b/test/fixtures/ssr/store/index.js
@@ -8,13 +8,13 @@ export const state = () => {
 }
 
 export const mutations = {
-  setId2 (state, id) {
+  setId2(state, id) {
     state.id2 = id
   }
 }
 
 export const actions = {
-  nuxtServerInit ({ commit, state }, { route }) {
+  nuxtServerInit({ commit, state }, { route }) {
     if (route.query.onServerInit === '1') {
       commit('setId2', nextId())
     }

diff --git a/test/fixtures/with-config/components/loading.vue b/test/fixtures/with-config/components/loading.vue
@@ -10,10 +10,10 @@ export default {
     loading: false
   }),
   methods: {
-    start () {
+    start() {
       this.loading = true
     },
-    finish () {
+    finish() {
       this.loading = false
     }
   }

diff --git a/test/fixtures/with-config/middleware/noop.js b/test/fixtures/with-config/middleware/noop.js
@@ -1,3 +1,3 @@
 export default function () {
-    // NOOP!
-}
+  // NOOP!
+}