-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Added test-results to file watcher ignore list #18210
base: main
Are you sure you want to change the base?
Fix: Added test-results to file watcher ignore list #18210
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this make sense as a default ignore. But projects with e2e tests could have also just added the config admin.watchIgnoreFiles
@innerdvations I am not in favor of this change. Adding a folder like that to the ignore list feels very arbitrary to me from a user pov. For me the underlying issue is that we do not have an explicit allowList and a ignoreList instead. Using |
I was viewing it more as a general quality of life improvement the same way we add commonly ignored things that are unrelated to strapi in the default project .gitignore. It's true it would interfere if someone legitimately had a test-results folder they wanted to watch But if we want to avoid adding more files to the ignore list, I'm also ok closing this and just improving documentation of watchIgnoreFiles instead. |
What does it do?
Added
test-results
folder to the list of ignored paths of file watcher.Why is it needed?
Fix: #18196
Users are facing issues while running E2E tests, as the server gets restarted during the tests.
How to test it?
Go to
examples/getstarted
Run
yarn develop
Create a new file (e.g. test-results/something.txt)
The server restart does not happen as it was happenning before
Related issue(s)/PR(s)
Issue: #18196