feat(helm): add topologySpreadConstraints and PDB #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any feedback on this? |
|
@the-technat can you please rebase with upstream master branch and force push so that CI passes. Thanks |
|
Should be rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there
First of all thank you very much for podinfo! It's such a nice app and I used it heavily in the last couple of days to check app availability during migration testing.
Duing so I found myself looking for config options to specify
topologySpreadConstraintsandpodDisruptionBudgetin the helm chart which I didn't found. They are often used to ensure maximum availability during upgrades.So here they are ;)
Tests done: only helm template locally