Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3805: Clean up fields #3825

Closed
wants to merge 3 commits into from
Closed

3805: Clean up fields #3825

wants to merge 3 commits into from

Conversation

dorner
Copy link
Collaborator

@dorner dorner commented Aug 11, 2023

Resolves #3805

Description

This performs two sets of cleanup:

  • Removes entirely columns from partner_profiles which I've determined are no longer referenced anywhere in the codebase.
  • Added ignored_columns to the User table to ensure that nothing breaks - these would be the next set of columns that is removed. I'm less sure about these so at the very least I wanted to run CI on them.

@cielf
Copy link
Collaborator

cielf commented Aug 11, 2023

Thanks!

@dorner dorner self-assigned this Mar 3, 2024
@github-actions github-actions bot added the stale label Apr 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

Automatically unassigned after 7 days of inactivity.

@dorner
Copy link
Collaborator Author

dorner commented Jun 9, 2024

Closing this for now - there are other things we need to look into first, like global barcodes.

@dorner dorner closed this Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review for unused fields --> clean up
3 participants
@dorner @cielf @awwaiid