Extract sidebar markup into helper #3801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The markup for the sidebar was copy/pasted many many times. This commit adds the following helpers: * `sidebar` - simply adds the appropriate ul wrapper for the sidebar to its block, which should have the other two helpers. * `sidebar_item` - Ensures that whenever the current page is the linked path, the item is active. Has an optional argument to be active for any path on the controller. * `sidebar_group` - Takes a list of items and ensures the group is open whenever any item under it is active. Can also take a controller similar to the item, useful if the sub-items are only some actions on a controller. Notably, this fixes: * Several instances where the path checked was not the path linked * Several places where an item would be active in a group that wasn't * The active checks in the admin sidebar all missing the admin/ prefix
5e8ca13
to
67494dc
Compare
|
I'd like to hold off on this refactor until after / separate from the dashboard update. |
|
This has been sitting for a long time. Dashboard has been merged now. I'm going to close this for now - I'm fine with reopening if there's desire to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The markup for the sidebar was copy/pasted many many times. This
PR adds the following helpers:
sidebar- simply adds the appropriate ul wrapper for the sidebarto its block, which should have the other two helpers.
sidebar_item- Ensures that whenever the current page is thelinked path, the item is active. Has an optional argument to be
active for any path on the controller.
sidebar_group- Takes a list of items and ensures the group isopen whenever any item under it is active. Can also take a
controller similar to the item, useful if the sub-items are only
some actions on a controller.
Notably, this fixes:
Type of change
How Has This Been Tested?
Manually clicking on all the sidebar links and verifying they go to the correct place and highlight afterwards