[Kit Redesign] Phase 1 - Change itemizable source #3750
+41
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o 3609-kit-allocation-should-create-inventory-in-out
…o 3609-kit-allocation-should-create-inventory-in-out
…o 3609-kit-allocation-should-create-inventory-in-out
…o 3609-kit-allocation-should-create-inventory-in-out
…o 3656-add-shipped-to-delivery-method
…o 3609-kit-allocation-should-create-inventory-in-out
…o 3656-add-shipped-to-delivery-method
…o 3609-kit-allocation-should-create-inventory-in-out
…o 3656-add-shipped-to-delivery-method
…o 3656-add-shipped-to-delivery-method
…o 3656-add-shipped-to-delivery-method
…o 3609-kit-allocation-should-create-inventory-in-out # Conflicts: # db/schema.rb
…han-haidar/human-essentials into 3609-kit-allocation-should-create-inventory-in-out
…o 3707-change-itemizable-source # Conflicts: # db/migrate/20230606061826_create_kit_allocations.rb # db/migrate/20230612075547_add_kit_allocation_type_to_kit_allocations.rb
dorner
requested changes
Jul 18, 2023
| @@ -1,8 +1,8 @@ | |||
| class KitsController < ApplicationController | |||
| def index | |||
| @kits = current_organization.kits.includes(line_items: :item, inventory_items: :storage_location).class_filter(filter_params) | |||
| @items = Item.where(partner_key: "kit").includes(line_items: :item, inventory_items: :storage_location).class_filter(filter_params) | |||
There was a problem hiding this comment.
Probably should use a join here instead of checking partner_key.
| @@ -14,6 +14,7 @@ | |||
| # | |||
|
|
|||
| class BaseItem < ApplicationRecord | |||
| include Itemizable | |||
There was a problem hiding this comment.
Sorry, the issue had some bad wording - this has to be added to the Item class, not BaseItem.
| @@ -0,0 +1,5 @@ | |||
| class ChangeItemizableId < ActiveRecord::Migration[7.0] | |||
| def change | |||
| Rake::Task['change_itemizable_id'].invoke | |||
There was a problem hiding this comment.
Why was this split into a Rake task?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3707
Description
Just created the draft PR to get pulse checked to see if I am in the right direction with my approach
Type of change
Screenshots