-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update select.md #7022
base: dev
Are you sure you want to change the base?
Update select.md #7022
Conversation
Hope this is ok. Scott
It's not good - the difference would be that filtering means selecting one/mode of the options in the list (even that means first adding the new option to the list) while autocomplete means completing the text you write with the text of the option in the list (but you can then delete/add some more text to it and use it as it is). |
Ahh... ok. I'll edit it accordingly. Scott |
@pdanpdan - Can you see if it is correct now? Thanks for helping out. Scott |
The intended difference between a filtering QSelect and an autocomplete QSelect is that the former only allows setting the model to options from the list of available options (even if that means first adding the new option to the list), while the latter allows setting the model to something that is not in the list (picking an option from the list only fills the model with the content of the option). |
@@ -140,6 +140,12 @@ You can dynamically load new options when scroll reaches the end: | |||
|
|||
## Filtering and autocomplete | |||
|
|||
### Understanding the difference | |||
|
|||
The intended difference between a filtering QSelect and an autocomplete QSelect is offering the user a set of options that could be the full intended text to be entered (autocomplete), or removing options in the selection according to the input by the user (filter). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is still confusing. Here's my suggestion:
The intended difference between a filtering QSelect and an autocomplete QSelect is that autocomplete allows you the model to accept a value that is not in the list of options, without adding it to the list. Filter on the other hand will result in a null or default value for the model if an option is not selected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would be good the technical part below. The first paragraph is what the user should expect, The second the developer.
Scott
Hope this is ok.
Scott
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch and not themaster
branchfix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: