Increased speed of generating and querying splines. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prime31
added a commit
that referenced
this pull request
Aug 5, 2015
Increased speed of generating and querying splines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increased speed of generating and querying splines (excluding straight-line solver) by removing the dictionary-based lookup table as it wasn't really used like a dictionary in the getPointOnPath(t) method. The replacement is a list of segment structs that is iterated over, avoiding the previous dictionary key copy-to-new-array during every getPointOnPath(t) query.
nb. this change does not affect the straight-line solver which still uses dictionary lookups.
There is a basic test included that compares current vs new spline building and querying.