fix: Rate limiting can fail when using Parse Server option rateLimit.redisUrl with clusters
#8632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #8632 +/- ##
==========================================
- Coverage 94.15% 94.14% -0.01%
==========================================
Files 186 186
Lines 14688 14687 -1
==========================================
- Hits 13829 13827 -2
- Misses 859 860 +1 ☔ View full report in Codecov by Sentry. |
|
Testing in production to confirm this PR fixes the issue |
|
What's the verdict after testing this out in production? |
mtrezza
approved these changes
Mar 24, 2024
rateLimit.redisUrl with clusters
mtrezza
approved these changes
Mar 24, 2024
parseplatformorg
pushed a commit
that referenced
this pull request
Mar 24, 2024
# [7.1.0-alpha.3](7.1.0-alpha.2...7.1.0-alpha.3) (2024-03-24) ### Bug Fixes * Rate limiting can fail when using Parse Server option `rateLimit.redisUrl` with clusters ([#8632](#8632)) ([c277739](c277739))
|
🎉 This change has been released in version 7.1.0-alpha.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Rate Limit with redisURL can fail if client is already opened.
Closes: #8631
Approach
Tasks