pathlib: Fix module path used when using importlib with namespaces #12313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12044
Will do other steps from the template, but before I would like a confirmation that this fix make sense.
It does fix the issue of assertion rewriting mixed with namespace package on in my environment.
If fixes both the cases where the tests lives in a package with
__init__.py
and with the configconsider_namespace_packages = true
. I am not familiar at all with this part of the code (or any to be honest), so I'm unsure what are the consequence, but from my understanding thefrom_spec(module, path)
path parameter should take the module parent path, not the source root.From the doc:
@nicoddemus since you seem the main maintainer of this part.
Thanks!