-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opinfo based testing of torch.bmm with Strided, COO, CSR, and CSC samples. #84572
Conversation
…ples. [ghstack-poisoned]
🔗 Helpful links
❌ 10 New FailuresAs of commit 3e85a6c (more details on the Dr. CI page): Expand to see more
🕵️ 9 new failures recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
…ples. ghstack-source-id: ba3551fff0a10ea3cf14d77212956c27d94db098 Pull Request resolved: #84572
Test bmm operation on tensors with various layouts. | ||
""" | ||
|
||
import torch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing changes look OK. @cpuhrsch is probably the best principal reviewer for this, but I'm not sure we want to add a new test file, especially not one with such a generic name
There should be existing tests for mm. My hope was that we could extend those with additional sparse inputs. @pearu is that feasible? |
…and CSC samples." [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84572
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 FailuresAs of commit 2363e23: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…and CSC samples." [ghstack-poisoned]
…ples. ghstack-source-id: 16e41eff278bb4b2fd3566ce1cf58375668cf4c0 Pull Request resolved: #84572
…and CSC samples." [ghstack-poisoned]
…and CSC samples." [ghstack-poisoned]
…ples. ghstack-source-id: 2ef5f2ff9d7c587ebe5fb754869d8def58c7c70e Pull Request resolved: #84572
…and CSC samples." [ghstack-poisoned]
…and CSC samples." [ghstack-poisoned]
…ples. ghstack-source-id: b247e93df1986671f0d851265b8ed2501140d336 Pull Request resolved: #84572
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Stack from ghstack (oldest at bottom):