Skip to content
This repository has been archived by the owner on Sep 4, 2022. It is now read-only.

Added og: image, og:url and robots meta tags to help SEO #193

Merged
merged 9 commits into from
Oct 25, 2019
Merged

Added og: image, og:url and robots meta tags to help SEO #193

merged 9 commits into from
Oct 25, 2019

Conversation

nautatva
Copy link
Contributor

Fix for https://github.com/webgems/webgems/issues/151 opengraph tags are added. Also added a point in PHP and icons

@netlify
Copy link

netlify bot commented Oct 21, 2019

Deploy preview for upbeat-albattani-cbe0ee ready!

Built with commit 14de25b

https://deploy-preview-193--upbeat-albattani-cbe0ee.netlify.com

Copy link
Owner

@lostdesign lostdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The opengraph preview doesnt show much as of now, unless the title and the icon. Maybe i should have been more precise with the end result. E.g. If you share the github repo of this, you will see the official image. At least this image should be shown and a short description.

"title": "Fontello",
"desc": "Fontello has a collection of icons from various font and icon toolkits and the icons can be individually selected and downloaded. This greatly improves the website performance owing the reduced css to download.",
"url": "http://fontello.com/",
"tags": ["tag"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either provide no tag at all or at least three tags that describe the resource.

@@ -67,6 +67,12 @@
"desc": "134 Slides to help fix your code. Performance and testing are just one aspect of code, to really be successful your code needs to be readable, maintainable and generally easier to comprehend and work with.",
"url": "https://www.slideshare.net/rdohms/your-code-sucks-lets-fix-it-15471808",
"tags": []
},
{
"title": "Stuck at a code? Let's find the problem",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This resource does not add much value to be honest. Linting should be done in the IDE and not by pasting it on some website. Can you please remove this?

@nautatva
Copy link
Contributor Author

Summary of the commit:

  • Made the description to tell a little more about webDevs, also includes keywords for SEO
  • Removed phpCodeChecker
  • Removed the extra tag from fontello
  • Linted the code properly
  • Added SEO tags which now include title and description as well
  • Referenced the title and description to a common package.json

@lostdesign lostdesign merged commit 42eabe0 into lostdesign:dev Oct 25, 2019
@lostdesign lostdesign added this to Approved and Done in ISSUES Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
ISSUES
  
Approved and Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants