Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added packeges to mockery config file #5626

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

added packeges to mockery config file #5626

wants to merge 2 commits into from

Conversation

danish9039
Copy link
Contributor

part of #5569

Description of the changes

  • added packages to mockery config file

How was this change tested?

  • make test

Checklist

@danish9039
added packeges to mockery config file
2d95130 
Signed-off-by: danish siddiqui <danishsiddiqui040@gmail.com>
@danish9039 danish9039 requested a review from a team as a code owner June 14, 2024 09:56
@codecov Codecov
Copy link

codecov bot commented Jun 14, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (1830148) to head (2b1e337).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5626      +/-   ##
==========================================
- Coverage   96.20%   96.19%   -0.02%     
==========================================
  Files         327      327              
  Lines       16014    16014              
==========================================
- Hits        15406    15404       -2     
- Misses        432      433       +1     
- Partials      176      177       +1
Flag Coverage Δ
badger_v1 8.05% <ø> (ø)
badger_v2 1.93% <ø> (ø)
cassandra-3.x-v1 16.45% <ø> (ø)
cassandra-3.x-v2 1.85% <ø> (ø)
cassandra-4.x-v1 16.45% <ø> (ø)
cassandra-4.x-v2 1.85% <ø> (ø)
elasticsearch-7.x-v1 18.89% <ø> (+0.01%) ⬆️
elasticsearch-8.x-v1 19.07% <ø> (-0.02%) ⬇️
elasticsearch-8.x-v2 19.07% <ø> (-0.02%) ⬇️
grpc_v1 9.48% <ø> (ø)
grpc_v2 7.53% <ø> (ø)
kafka 9.77% <ø> (ø)
opensearch-1.x-v1 18.93% <ø> (ø)
opensearch-2.x-v1 18.93% <ø> (ø)
opensearch-2.x-v2 18.94% <ø> (ø)
unittests 94.06% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danish9039
fix
2b1e337 
Signed-off-by: danish siddiqui <danishsiddiqui040@gmail.com>
@yurishkuro
Copy link
Member

Build is failing. Adding new packages is likely to cause changes to generated files, so you need to check them in too, and make sure that tests are green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavolloffay pavolloffay Awaiting requested review from pavolloffay pavolloffay is a code owner automatically assigned from jaegertracing/jaeger-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
changelog:bugfix-or-minor-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danish9039 @yurishkuro