Upgrade HotROD example to use OpenTelemetry SDK #3380

yurishkuro · 2021-11-08T15:59:35Z

replace Jaeger SDK with OTEL SDK using an OT Bridge
replace OT instrumentation with OpenTelemetry
Remove references to OpenTracing API
- from HotROD code
- from HotROD tests examples/hotrod/pkg/tracing/rpcmetrics/
- from README Remove unneeded references to OpenTracing #4790
Remove Jaeger exporter, leave only OTLP, and update README and docker-compose

The text was updated successfully, but these errors were encountered:

rbroggi · 2021-11-08T19:21:11Z

Will try to work on that during the next weekend.

rbroggi · 2021-11-11T11:46:35Z

Before jumping right into the code I have been studying the opentelemetry go API. Given that the notion of logs is not complete in opentelemetry yet but is something used in Jaeger, I wanted to make sure we have a strategy to migrate what is currently 'logged' in HotROD to what in opentelemetry is called an 'Event'. Is this a good understanding? The only other option in open telemetry is to use Attributes (key-value) which are what in jaeger-client we call Tags.

in the article there is also a section that describes the difference between tags vs Logs.

yurishkuro · 2021-11-11T13:22:17Z

Let me clarify - at this time our intention is not to upgrade everything to OTEL API, but keep OT instrumentation and use OT-to-OTEL bridge to replace Jaeger SDK with OTEL SDK. Therefore your question is not relevant because that decision will be made by the bridge.

rbroggi · 2021-11-11T13:54:44Z

Let me clarify - at this time our intention is not to upgrade everything to OTEL API, but keep OT instrumentation and use OT-to-OTEL bridge to replace Jaeger SDK with OTEL SDK. Therefore your question is not relevant because that decision will be made by the bridge.

Copy that! I'm glad I asked the question! 😄

@rbroggi

Based on earlier PR #3390 by @rbroggi. ## Which problem is this PR solving? - Resolves #3380 ## Short description of the changes - Switch from jaeger-client-go SDK to OTel SDK paired with ot-otel bridge - Add cli flag to select which Otel Exporter to use (Jaeger, OTLP or stdout) - Add favicon 🚗 - Added OTEL version of rpcmetrics from jaeger-client-go - Remove dependency on github.com/uber/jaeger-lib in HotROD (addresses one of outstanding tasks in #3766) --------- Signed-off-by: rbroggi <ro_broggi@hotmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: rbroggi <ro_broggi@hotmail.com>

@rbroggi

Based on earlier PR jaegertracing#3390 by @rbroggi. ## Which problem is this PR solving? - Resolves jaegertracing#3380 ## Short description of the changes - Switch from jaeger-client-go SDK to OTel SDK paired with ot-otel bridge - Add cli flag to select which Otel Exporter to use (Jaeger, OTLP or stdout) - Add favicon 🚗 - Added OTEL version of rpcmetrics from jaeger-client-go - Remove dependency on github.com/uber/jaeger-lib in HotROD (addresses one of outstanding tasks in jaegertracing#3766) --------- Signed-off-by: rbroggi <ro_broggi@hotmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: rbroggi <ro_broggi@hotmail.com>

@rbroggi

Based on earlier PR jaegertracing#3390 by @rbroggi. ## Which problem is this PR solving? - Resolves jaegertracing#3380 ## Short description of the changes - Switch from jaeger-client-go SDK to OTel SDK paired with ot-otel bridge - Add cli flag to select which Otel Exporter to use (Jaeger, OTLP or stdout) - Add favicon 🚗 - Added OTEL version of rpcmetrics from jaeger-client-go - Remove dependency on github.com/uber/jaeger-lib in HotROD (addresses one of outstanding tasks in jaegertracing#3766) --------- Signed-off-by: rbroggi <ro_broggi@hotmail.com> Signed-off-by: Yuri Shkuro <github@ysh.us> Co-authored-by: rbroggi <ro_broggi@hotmail.com> Signed-off-by: shubbham1215 <sawaikershubham@gmail.com>

## Which problem is this PR solving? Related to #3380 Part of #3381 - This adds `OTEL tracerProvider` and removes `OT tracer` for Redis service hotROD app Before: ![r2](https://github.com/jaegertracing/jaeger/assets/11625672/446d03b9-2da0-47b2-9312-b8bc86c7e78a) After: ![r1](https://github.com/jaegertracing/jaeger/assets/11625672/ed3f2ca6-7a01-4ab2-a13c-56c1f3388fe6) --------- Signed-off-by: afzal442 <afzal442@gmail.com> Co-authored-by: Afzal <94980910+afzalbin64@users.noreply.github.com>

## Which problem is this PR solving? Related to jaegertracing#3380 Part of jaegertracing#3381 - This adds `OTEL tracerProvider` and removes `OT tracer` for Redis service hotROD app Before: ![r2](https://github.com/jaegertracing/jaeger/assets/11625672/446d03b9-2da0-47b2-9312-b8bc86c7e78a) After: ![r1](https://github.com/jaegertracing/jaeger/assets/11625672/ed3f2ca6-7a01-4ab2-a13c-56c1f3388fe6) --------- Signed-off-by: afzal442 <afzal442@gmail.com> Co-authored-by: Afzal <94980910+afzalbin64@users.noreply.github.com> Signed-off-by: KevinSchneider <kevin.schneider@target.com>

## Which problem is this PR solving? Related to #3380 Part of #3381 ## Short description of the changes - This PR adds OTEL instrumentation to customer svc --------- Signed-off-by: Afzal Ansari <afzal442@gmail.com>

## Which problem is this PR solving? - Part of #3380 ## Short description of the changes - Move explicit baggage access into a util func that checks both OT and OTEL baggage. Later the OT part can be retired completely. - Update usage sites to use the new function instead of OT `Span.BaggageItem` A couple of less related changes in `tracing/mutex.go`: - Use OTEL Span API instead of OT - Replace direct-to-span logging with the regular logger that logs both to stdout and to the span Signed-off-by: Yuri Shkuro <github@ysh.us>

## Which problem is this PR solving? Related to jaegertracing#3380 Part of jaegertracing#3381 ## Short description of the changes - This PR adds OTEL instrumentation to customer svc --------- Signed-off-by: Afzal Ansari <afzal442@gmail.com>

## Which problem is this PR solving? - Part of jaegertracing#3380 ## Short description of the changes - Move explicit baggage access into a util func that checks both OT and OTEL baggage. Later the OT part can be retired completely. - Update usage sites to use the new function instead of OT `Span.BaggageItem` A couple of less related changes in `tracing/mutex.go`: - Use OTEL Span API instead of OT - Replace direct-to-span logging with the regular logger that logs both to stdout and to the span Signed-off-by: Yuri Shkuro <github@ysh.us> Signed-off-by: Afzal Ansari <afzal442@gmail.com>

## Which problem is this PR solving? * Part of #3380 * This PR tries to instrument the hotROD app with otel downgrading opentracing. Related #4533 (comment) ## Short description of the changes - Upgrades hotROD application to support `otel tracer` --------- Signed-off-by: Afzal Ansari <afzal442@gmail.com> Signed-off-by: afzal442 <afzal442@gmail.com> Signed-off-by: Afzal <94980910+afzalbin64@users.noreply.github.com> Co-authored-by: Afzal <94980910+afzalbin64@users.noreply.github.com>

yurishkuro · 2023-07-16T02:51:25Z

getting close to completing this

## Which problem is this PR solving? - Part of #3380 Signed-off-by: Yuri Shkuro <github@ysh.us>

## Which problem is this PR solving? Since the HotROD UI does not start traces, it can only search for a trace corresponding to a particular request by some span tags. This makes the experience of opening a trace a big clunky as we first see the search page with one trace, and then have to click on the trace again. Related to #3380 ## Short description of the changes Change the HTTP instrumentation to always generate a `traceresponse` header per the [current W3C draft](https://github.com/w3c/trace-context/blob/main/spec/21-http_response_header_format.md). Then parse the trace ID from that header in the UI and generate a hyperlink to open the trace view directly, bypassing the search. --------- Signed-off-by: Yuri Shkuro <github@ysh.us>

yurishkuro · 2023-09-28T16:06:29Z

The only remaining references to opentracing are in documentation files, still need to clean them up:

./README.md:71:### Native support for OpenTracing
./README.md:73:Jaeger backend, Web UI, and instrumentation libraries have been designed from the ground up to support the [OpenTracing standard](https://opentracing.io/specification/).
./README.md:74:  * Represent traces as directed acyclic graphs (not just trees) via [span references](https://github.com/opentracing/specification/blob/master/specification.md#references-between-spans)
./README.md:82:The OpenTracing and OpenCensus projects have merged into a new CNCF project...
./CONTRIBUTING.md:103:      hotrod/               - Demo application that uses OpenTracing API
./examples/hotrod/README.md:6:  * as a blog post [Take OpenTracing for a HotROD ride][hotrod-tutorial],
./examples/hotrod/README.md:90:[hotrod-tutorial]: https://medium.com/@YuriShkuro/take-opentracing-for-a-hotrod-ride-f6e3141f7941
./examples/opentracing-tutorial/README.md:1:# OpenTracing Instrumentation Tutorial
./examples/opentracing-tutorial/README.md:3:To learn how to instrument your own applications for distributed tracing with Jaeger and OpenTracing API,
./examples/opentracing-tutorial/README.md:4:please see https://github.com/yurishkuro/opentracing-tutorial/.
./docker-compose/monitor/grafana.ini:1025:# Opentracing is deprecated use opentelemetry instead

Resolves #3380 Signed-off-by: Yuri Shkuro <github@ysh.us>

yurishkuro added the help wanted Features that maintainers are willing to accept but do not have cycles to implement label Nov 8, 2021

yurishkuro mentioned this issue Nov 8, 2021

🌇 Sunsetting Jaeger clients 🏁 #3362

Closed

9 tasks

rbroggi mentioned this issue Nov 14, 2021

Use OpenTelemetry SDK in HotROD #3390

Closed

yurishkuro mentioned this issue Jun 21, 2022

Remove dependency on jaeger-lib #3766

Open

5 tasks

yurishkuro mentioned this issue Jan 29, 2023

Use OpenTelemetry SDK in HotROD 🚗 #4187

Merged

yurishkuro closed this as completed in #4187 Jan 29, 2023

afzal442 mentioned this issue Jun 17, 2023

feat: Added OTEL TracerProvider instead of opentracing.Tracer for hotROD example app service (Redis) #4533

Merged

This was referenced Jul 2, 2023

[hotROD] Replace gRPC instrumentation with OTEL #4558

Merged

[hotROD] Add OTEL instrumentation to customer svc #4559

Merged

This was referenced Jul 6, 2023

[hotROD] Upgrade hotrod to support otel tracer #4548

Merged

[hotrod] Handle both OT and OTEL baggage #4572

Merged

yurishkuro mentioned this issue Jul 16, 2023

[hotrod] Remove most references to OpenTracing #4585

Merged

yurishkuro reopened this Jul 16, 2023

yurishkuro mentioned this issue Jul 16, 2023

[hotrod] Return trace ID via traceresponse header #4584

Merged

yurishkuro added a commit that referenced this issue Jul 16, 2023

[hotrod] Remove most references to OpenTracing (#4585)

7b6cd83

## Which problem is this PR solving? - Part of #3380 Signed-off-by: Yuri Shkuro <github@ysh.us>

yurishkuro mentioned this issue Sep 28, 2023

Remove unneeded references to OpenTracing #4790

Merged

yurishkuro closed this as completed in #4790 Sep 28, 2023

yurishkuro added a commit that referenced this issue Sep 28, 2023

Remove unneeded references to OpenTracing (#4790)

f5e5f28

Resolves #3380 Signed-off-by: Yuri Shkuro <github@ysh.us>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade HotROD example to use OpenTelemetry SDK #3380

Upgrade HotROD example to use OpenTelemetry SDK #3380

yurishkuro commented Nov 8, 2021 •

edited

rbroggi commented Nov 8, 2021

rbroggi commented Nov 11, 2021 •

edited

yurishkuro commented Nov 11, 2021

rbroggi commented Nov 11, 2021

yurishkuro commented Jul 16, 2023

yurishkuro commented Sep 28, 2023

Upgrade HotROD example to use OpenTelemetry SDK #3380

Upgrade HotROD example to use OpenTelemetry SDK #3380

Comments

yurishkuro commented Nov 8, 2021 • edited

rbroggi commented Nov 8, 2021

rbroggi commented Nov 11, 2021 • edited

yurishkuro commented Nov 11, 2021

rbroggi commented Nov 11, 2021

yurishkuro commented Jul 16, 2023

yurishkuro commented Sep 28, 2023

yurishkuro commented Nov 8, 2021 •

edited

rbroggi commented Nov 11, 2021 •

edited