Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Let Android logs respect flutter --verbose flag #106569

Closed
wants to merge 1 commit into from

Conversation

kalabro
Copy link

@kalabro kalabro commented Jun 24, 2022

Default Android log reader doesn't filter logcat records. On large codebases, it generates a lot of noise on futter run. This PR reverts default behaviour to filtering Android logs by "flutter" string with the ability to see all logs if the --verbose flag is passed to the flutter command-line tool.

Related issues:

#50808, #104268

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 24, 2022
@google-cla
Copy link

google-cla bot commented Jun 24, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kalabro kalabro changed the title Let Android logs respect flutter --verbose flag [WIP] Let Android logs respect flutter --verbose flag Jun 24, 2022
@flutter-dashboard
Copy link

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@christopherfujino
Copy link
Member

Two things:

  1. you appear to have broken CI tests
  2. did you address the reasons why the original PR for this was reverted? I believe there is more context on the tracking issue: Feature request: Add a flag to flutter run & flutter logs to filter output #50808

@kalabro
Copy link
Author

kalabro commented Jul 30, 2022

hi @christopherfujino, thank you for reviewing my PR.
I'm not sure if my approach is correct after reading the mentioned issue. I left a comment with my thoughts here: #50808 (comment)
Could you please help me find the right approach? I'll then fix the tests.

@christopherfujino
Copy link
Member

hi @christopherfujino, thank you for reviewing my PR. I'm not sure if my approach is correct after reading the mentioned issue. I left a comment with my thoughts here: #50808 (comment) Could you please help me find the right approach? I'll then fix the tests.

Unfortunately, the difficult part about re-landing this change is investigating the post-submit devicelab failures and either updating the tests to no longer rely on logs that get filtered by this change, or make the filtering more robust to include whatever the test was relying on.

Also unfortunately, I don't have the capacity right now to do this investigation for you.

@kalabro
Copy link
Author

kalabro commented Jul 30, 2022

No worries @christopherfujino, I'll find something less tricky to get started.

@kalabro kalabro closed this Jul 30, 2022
@kalabro kalabro deleted the android-logs branch July 30, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants