-
Notifications
You must be signed in to change notification settings - Fork 26.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Let Android logs respect flutter --verbose flag #106569
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Two things:
|
hi @christopherfujino, thank you for reviewing my PR. |
Unfortunately, the difficult part about re-landing this change is investigating the post-submit devicelab failures and either updating the tests to no longer rely on logs that get filtered by this change, or make the filtering more robust to include whatever the test was relying on. Also unfortunately, I don't have the capacity right now to do this investigation for you. |
No worries @christopherfujino, I'll find something less tricky to get started. |
Default Android log reader doesn't filter logcat records. On large codebases, it generates a lot of noise on
futter run
. This PR reverts default behaviour to filtering Android logs by "flutter" string with the ability to see all logs if the--verbose
flag is passed to theflutter
command-line tool.Related issues:
#50808, #104268
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.