-
Notifications
You must be signed in to change notification settings - Fork 26.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix _RenderValueIndicator
leak
#147451
Fix _RenderValueIndicator
leak
#147451
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
cc: @polina-c |
flutter/flutter@f9933b6...db8c475 2024-04-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5c6d4ffb66bd to 752b146df767 (2 revisions) (flutter/flutter#147487) 2024-04-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 20fb62ba1455 to 5c6d4ffb66bd (2 revisions) (flutter/flutter#147480) 2024-04-28 102401667+Dimilkalathiya@users.noreply.github.com Fix `_RenderValueIndicator` leak (flutter/flutter#147451) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…#6622) flutter/flutter@f9933b6...db8c475 2024-04-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5c6d4ffb66bd to 752b146df767 (2 revisions) (flutter/flutter#147487) 2024-04-28 engine-flutter-autoroll@skia.org Roll Flutter Engine from 20fb62ba1455 to 5c6d4ffb66bd (2 revisions) (flutter/flutter#147480) 2024-04-28 102401667+Dimilkalathiya@users.noreply.github.com Fix `_RenderValueIndicator` leak (flutter/flutter#147451) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Part of #141198
Fixes memory leak on
_RenderValueIndicator
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.