chore: Sign with HSM #1498
Merged
chore: Sign with HSM #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we'll sign using Digicert Keylocker. I've already removed the old (now revoked) certificate and added the required environment variables.
Things to comment on in this PR:
@dsanders11 I saw that you added
bash.exeas the default and I'm sorry to say that Windows subsystem stuff likemsiexecare simply too hard to actually get right in bash. In bash, you wait for the installation of an MSI by looping through the MSDOStasklistcommand and parsing the output, trying to figure out if it's still running. In Powershell, you just pipe toWait-Process, which is a whole lot less brittle.I'm going with Powershell instead! We don't need to change our defaults, but here, I think it's the right choice for Windows.
SIGN_OR_DIEis now the default assignWithParamswill throw if signing doesn't work. With it, I've replaced add-windows-cert.ts with a ps1 oneliner.Confirmed that the builds work, too! Test run here: https://app.circleci.com/pipelines/github/electron/fiddle/1188/workflows/970eceda-bab0-47b0-b656-8cc3ca652704/jobs/4602/steps