build: move Electron releases fetch to Forge generateAssets hook (#1316)

electron · Apr 18, 2023 · b11e77b · b11e77b
1 parent 6d2532e
commit b11e77b
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 48 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -19,6 +19,7 @@ commands:
       - run: npm install --global yarn
       - run: yarn install --frozen-lockfile
       - run: yarn run contributors
+      - run: yarn run electron-releases
       - save_cache:
           paths:
             - node_modules

diff --git a/.github/workflows/electron-releases.yml b/.github/workflows/electron-releases.yml
diff --git a/.gitignore b/.gitignore
@@ -38,6 +38,7 @@ report.json
 # Electron Fiddle-Specific
 /static/contributors.json
 /static/css/root.css
+/static/releases.json
 
 # Webpack configurations
-.webpack
+.webpack
diff --git a/forge.config.js b/forge.config.js
@@ -3,6 +3,7 @@ const path = require('path');
 
 const packageJson = require('./package.json');
 const { maybeFetchContributors } = require('./tools/contributors');
+const { populateReleases } = require('./tools/fetch-releases');
 
 const { version } = packageJson;
 const iconDir = path.resolve(__dirname, 'assets', 'icons');
@@ -27,7 +28,7 @@ const commonLinuxConfig = {
 const config = {
   hooks: {
     generateAssets: async () => {
-      await maybeFetchContributors(true);
+      await Promise.all([populateReleases(), maybeFetchContributors(true)]);
     },
   },
   plugins: [

diff --git a/static/releases.json b/static/releases.json
diff --git a/tests/globalSetup.js b/tests/globalSetup.js
@@ -1,7 +1,8 @@
 const { maybeFetchContributors } = require('../tools/contributors');
+const { populateReleases } = require('../tools/fetch-releases');
 
 async function globalSetup() {
-  await maybeFetchContributors(true);
+  await Promise.all([maybeFetchContributors(true), populateReleases()]);
 }
 
 module.exports = globalSetup;
diff --git a/tools/fetch-releases.js b/tools/fetch-releases.js
@@ -15,7 +15,7 @@ async function getReleases() {
   return await response.json();
 }
 
-async function main() {
+async function populateReleases() {
   const data = await getReleases();
   const releases = data.map(({ version, node }) => ({ version, node }));
 
@@ -27,4 +27,12 @@ async function main() {
   console.log('Updating tests with new expected version count.');
 }
 
-main();
+module.exports = {
+  populateReleases,
+};
+
+if (require.main === module) {
+  (async () => {
+    await populateReleases();
+  })();
+}