-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: multiplayer undo / redo #7348
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Mrazator
force-pushed
the
mrazator/granular-history
branch
from
November 27, 2023 19:10
d37400a
to
da7df3c
Compare
Mrazator
force-pushed
the
mrazator/granular-history
branch
from
November 30, 2023 16:35
39c4dc5
to
9ec206a
Compare
Mrazator
force-pushed
the
mrazator/granular-history
branch
from
November 30, 2023 18:03
9ec206a
to
973d1b5
Compare
Mrazator
force-pushed
the
mrazator/granular-history
branch
from
December 4, 2023 21:33
c277b12
to
e918298
Compare
Mrazator
force-pushed
the
mrazator/granular-history
branch
from
December 4, 2023 21:54
e918298
to
04d606a
Compare
Mrazator
force-pushed
the
mrazator/granular-history
branch
from
April 16, 2024 22:11
eade626
to
c1a3b89
Compare
dwelle
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥🚀
This was referenced Apr 18, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR; Added support for multiplayer undo/redo, by calculating invertible increments and storing them inside the local-only undo/redo stacks.
Other smaller changes include:
For more details check the high-level description of the introduced and modified components below.
Scene: https://link.excalidraw.com/readonly/jaraG0I63Qj6pPxqHVGn
History (modified)
Store (introduced)
Change (introduced)
ElementsChange
, which mostly relates to the text container bindings in the multiplayer scenarios (specific cases covered in here.AppStateChange
(purely local) andElementsChange
(local, but could conflict with remote changes).id
,type
,source
, and logicaltimestamp
, which would extend it with CRDT-like characteristics.Delta (introduced)
deleted
andinserted
partials, wheredeleted
is a set of all the previous (removed) values andinserted
is a set of all the next (added, updated) values.deleted
withinserted
and vice versa - as visible here.Delta
format take a look at the following gist.