Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] App Store CLI - Make it super easy to add an app. #2917

Merged
merged 54 commits into from
Jun 7, 2022
Merged

[Feature] App Store CLI - Make it super easy to add an app. #2917

merged 54 commits into from
Jun 7, 2022

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented May 30, 2022 •
edited

What does this PR do?

Updated Demo with creation/deletion/editing of app - https://www.loom.com/share/b850dafcfe454346b7cc33764d031faa

App Store Cli - Features

  • Create an App yarn app-store create
  • Quickly Edit basic details using cli yarn app-store edit --slug
  • Delete the app[Cleans up DB as well] yarn app-store delete --slug

See roadmap in app-store-cli/README.md

Separated "unification of appId and type" from this PR to avoid complexity. Work going on for that in #2953

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works

@vercel
Copy link

vercel bot commented May 30, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Jun 7, 2022 at 5:46AM (UTC)
3 Ignored Deployments
Name Status Preview Updated
docs ⬜️ Ignored (Inspect) Jun 7, 2022 at 5:46AM (UTC)
swagger ⬜️ Ignored (Inspect) Jun 7, 2022 at 5:46AM (UTC)
ui ⬜️ Ignored (Inspect) Jun 7, 2022 at 5:46AM (UTC)

@hariombalhara hariombalhara marked this pull request as ready for review June 3, 2022 09:16
@hariombalhara hariombalhara marked this pull request as draft June 3, 2022 09:16
@hariombalhara hariombalhara merged commit 18e0f13 into main Jun 7, 2022
@hariombalhara hariombalhara deleted the feature/app-store-cli branch June 7, 2022 06:13
@hariombalhara hariombalhara mentioned this pull request Jun 7, 2022
Merged
@zomars zomars mentioned this pull request Jun 15, 2022
Merged
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zomars zomars zomars approved these changes

@baileypumfleet baileypumfleet Awaiting requested review from baileypumfleet

@emrysal emrysal Awaiting requested review from emrysal

Assignees
No one assigned
Labels
♻️ autoupdate tells kodiak to keep this branch up-to-date 🐛 bug Something isn't working core area: core, team members only
Projects
No open projects
Cal.com Core Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hariombalhara @PeerRich @zomars