Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App/exchange v2 #2493

Merged
merged 30 commits into from
Jun 13, 2022
Merged

App/exchange v2 #2493

merged 30 commits into from
Jun 13, 2022
+975 −14

Conversation

zomars
Copy link
Member

@zomars zomars commented Apr 14, 2022 •
edited by joeauyeung

Reopens #2376

What does this PR do?

Adds Microsoft Exchange 2013 and 2016 to the app store.

This branch is created from main rather than the old monorepo/app-store

Fixes #2141

Type of change

  • New feature (non-breaking change which adds functionality)

How should this be tested?

  • Go to the app store
  • Go to the Microsoft Exchange 2013 & 2016 pages
  • Click install app and the page to input your Exchange credentials should popup

@vercel
Copy link

vercel bot commented Apr 14, 2022 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

docs – ./apps/docs

🔍 Inspect: https://vercel.com/cal/docs/9Z9teNh6qos31USF7NnZCNNdp6os
✅ Preview: In Progress

[Deployment for e7035cd canceled]

calendso – ./apps/web

🔍 Inspect: https://vercel.com/cal/calendso/JDSxTav9UWCpxnYqhqb81DcHe8RS
✅ Preview: In Progress

[Deployment for e7035cd failed]

@vercel vercel bot temporarily deployed to Preview – calendso April 14, 2022 22:27 Inactive
@vercel vercel bot temporarily deployed to Preview – docs April 14, 2022 22:27 Inactive
@vercel
Copy link

vercel bot commented May 4, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ✅ Ready (Inspect) Visit Preview Jun 13, 2022 at 10:11PM (UTC)
cal-dev ❌ Failed (Inspect) Jun 13, 2022 at 10:11PM (UTC)
3 Ignored Deployments
Name Status Preview Updated
docs ⬜️ Ignored (Inspect) Jun 13, 2022 at 10:11PM (UTC)
swagger ⬜️ Ignored (Inspect) Jun 13, 2022 at 10:11PM (UTC)
ui ⬜️ Ignored (Inspect) Jun 13, 2022 at 10:11PM (UTC)

@PeerRich
Copy link
Member

@zomars do you need reviews?

@PeerRich PeerRich requested a review from joeauyeung May 13, 2022 12:24
@vercel vercel bot temporarily deployed to Preview – cal-dev May 13, 2022 12:27 Inactive
@joeauyeung
Copy link
Contributor

@zomars do we need to add the app's data to seed-app-store.ts?

@zomars
Copy link
Member Author

zomars commented May 13, 2022

@joeauyeung @PeerRich This PR is a little stale. Will re-draft until is properly updated.

@zomars zomars marked this pull request as draft May 13, 2022 18:40
@ciaranha ciaranha added the app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar label May 18, 2022
@ciaranha ciaranha added this to the v.1.7 milestone May 18, 2022
@joeauyeung joeauyeung marked this pull request as ready for review June 13, 2022 13:35
@joeauyeung joeauyeung requested a review from a team June 13, 2022 13:36
leog
leog suggested changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@leog leog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @joeauyeung. Left a few comments to tackle 😉

packages/app-store/exchange2013calendar/_metadata.ts Show resolved Hide resolved
packages/app-store/exchange2016calendar/_metadata.ts Show resolved Hide resolved
packages/app-store/exchange2013calendar/pages/setup/index.tsx Outdated Show resolved Hide resolved
packages/app-store/exchange2016calendar/pages/setup/index.tsx Outdated Show resolved Hide resolved
zomars
zomars commented Jun 13, 2022
View reviewed changes
packages/app-store/exchange2013calendar/pages/setup/index.tsx
defaultValues: {
username: "",
password: "",
url: process.env.EXCHANGE_DEFAULT_EWS_URL || "",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joeauyeung is this env documented somewhere? EXCHANGE_DEFAULT_EWS_URL

packages/app-store/exchange2016calendar/_metadata.ts Show resolved Hide resolved
@zomars zomars requested a review from leog June 13, 2022 19:39
@zomars zomars merged commit 1960046 into main Jun 13, 2022
@zomars zomars deleted the app/exchange-v2 branch June 13, 2022 22:12
@zomars zomars mentioned this pull request Jun 15, 2022
Merged
@riedel riedel mentioned this pull request Jul 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeauyeung joeauyeung Awaiting requested review from joeauyeung

@leog leog Awaiting requested review from leog

Assignees

@joeauyeung joeauyeung

Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar
Projects
No open projects
Cal.com Core Roadmap
Status: In Review
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

Exchange App
5 participants
@zomars @PeerRich @joeauyeung @leog @ciaranha