Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgraded prisma to v3.0.2 #1284

Merged
merged 23 commits into from
Dec 21, 2021
Merged

upgraded prisma to v3.0.2 #1284

merged 23 commits into from
Dec 21, 2021

Conversation

alishaz-polymath
Copy link
Member

@alishaz-polymath alishaz-polymath commented Dec 9, 2021 •
edited

This PR:

  • Upgrades prisma to v3.0.2
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@linear
Copy link

linear bot commented Dec 9, 2021

CAL-754 Upgrade Prisma to 3.0.2

Upgrade Prisma version to 3.0.2 which is the most stable Prisma 3 version at this point.

@vercel
Copy link

vercel bot commented Dec 9, 2021 •
edited

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cal/calendso/3xU7y33wpSum8pdUppb57f5gkMqX
✅ Preview: https://calendso-git-cal-754-upgrade-prisma-to-302-cal.vercel.app

@vercel vercel bot temporarily deployed to Preview December 9, 2021 07:30 Inactive
@vercel vercel bot temporarily deployed to Preview December 9, 2021 07:35 Inactive
@vercel vercel bot temporarily deployed to Preview December 15, 2021 10:44 Inactive
@vercel vercel bot temporarily deployed to Preview December 15, 2021 11:06 Inactive
@vercel vercel bot temporarily deployed to Preview December 15, 2021 14:44 Inactive
@vercel vercel bot temporarily deployed to Preview December 17, 2021 09:15 Inactive
@vercel vercel bot temporarily deployed to Preview December 17, 2021 11:07 Inactive
@alishaz-polymath alishaz-polymath marked this pull request as ready for review December 17, 2021 11:07
@vercel vercel bot temporarily deployed to Preview December 17, 2021 11:34 Inactive
@zomars zomars added the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Dec 17, 2021
@vercel vercel bot temporarily deployed to Preview December 17, 2021 15:25 Inactive
zomars
zomars approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member

@zomars zomars left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing, the only quirk I remember from this upgrade is to make sure nested deletes work properly. But we don't use those IIRC so we're good to go.

EDIT: We should make sure these methods run fine after upgrading:

image

@vercel vercel bot temporarily deployed to Preview December 17, 2021 20:38 Inactive
@zomars zomars added ❗️ migrations contains migration files and removed 🧪 testing needed labels Dec 17, 2021
@vercel vercel bot temporarily deployed to Preview December 18, 2021 10:45 Inactive
@vercel vercel bot temporarily deployed to Preview December 18, 2021 15:06 Inactive
@vercel vercel bot temporarily deployed to Preview December 19, 2021 12:12 Inactive
@vercel vercel bot temporarily deployed to Preview December 19, 2021 21:02 Inactive
@vercel vercel bot temporarily deployed to Preview December 20, 2021 07:19 Inactive
@vercel vercel bot temporarily deployed to Preview December 20, 2021 09:12 Inactive
@vercel vercel bot temporarily deployed to Preview December 20, 2021 10:39 Inactive
@vercel vercel bot temporarily deployed to Preview December 20, 2021 11:56 Inactive
@vercel vercel bot temporarily deployed to Preview December 20, 2021 15:01 Inactive
@vercel vercel bot temporarily deployed to Preview December 20, 2021 16:27 Inactive
@vercel vercel bot temporarily deployed to Preview December 21, 2021 00:59 Inactive
@vercel vercel bot temporarily deployed to Preview December 21, 2021 12:24 Inactive
@zomars zomars merged commit bab72f1 into main Dec 21, 2021
@zomars zomars deleted the cal-754-upgrade-prisma-to-302 branch December 21, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zomars zomars zomars approved these changes

@emrysal emrysal Awaiting requested review from emrysal

@baileypumfleet baileypumfleet Awaiting requested review from baileypumfleet

Assignees
No one assigned
Labels
♻️ autoupdate tells kodiak to keep this branch up-to-date ❗️ migrations contains migration files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alishaz-polymath @zomars @baileypumfleet