Stop drawing when mouse is released outside of the canvas #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when a user draws on the canvas and clicks mouse button on any element outside of it, mousemove event still continues triggering drawing action on the canvas (since mouseup event isn't called on it).
Steps to reproduce (example):
Draw something on the canvas and without releasing a mouse, try to change the color. Color input will open and the app will continue drawing simultaneously.
Some possible solutions: