glowRepeatCount variable added to repeat animation a specific number of times #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aytunch
approved these changes
Apr 15, 2024
|
@apgapg Please review |
floodoo
reviewed
May 18, 2024
Comment on lines
82
to
+83
| if (mounted) { | ||
| if (widget.repeat) { | ||
| _controller.repeat(); | ||
| if (widget.glowRepeatCount > 0) { |
There was a problem hiding this comment.
For reasons of readability, I would write this in a single If branch
if (mounted && widget.glowRepeatCount > 0)
| @@ -64,6 +64,7 @@ AvatarGlow( | |||
| glowShape: BoxShape.circle, | |||
| animate: _animate, | |||
| curve: Curves.fastOutSlowIn, | |||
| glowRepeatCount: 5 // Animation will be repeated 5 times | |||
There was a problem hiding this comment.
Here I would keep it the same as the other parameters. Either comment on all of them or leave out the comment
|
It would be very nice if you could merge the PR as I, like many others, need this feature. @apgapg |
|
Sure would do In few hrs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The animation will be repeated 5 times as glowRepeatCount is set to 5. If this value is not passed then it will have existing behaviour.
Code:
Screen.Recording.2024-04-10.at.4.27.15.PM.mov
Description
Type of Change