Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWEEP: Reviewed usage of atomic numeric type methods #927

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

NightOwl888
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Summary of the changes (Less than 80 chars)

SWEEP: Reviewed usage of atomic numeric type methods

Fixes #917

Description

This aligns usages of GetAndAdd(), AddAndGet(), IncrementAndGet(), GetAndIncrement(), DecrementAndGet(), and GetAndDecrement() match Lucene (for both AtomicInt32 and AtomicInt64). There were no significant issues found, but some of the adjacent code was corrected to use the correct types, casts, and formatting in the invariant culture.

@NightOwl888 NightOwl888 merged commit 63e1053 into apache:master Mar 11, 2024
199 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit use of AtomicInt32 and AtomicInt64 methods
1 participant