Skip to content

Commit

Permalink
Move net5.0 warning suppression to combined group
Browse files Browse the repository at this point in the history
  • Loading branch information
paulirwin committed Mar 28, 2024
1 parent 72a7ab0 commit 51eb651
Showing 1 changed file with 3 additions and 5 deletions.
8 changes: 3 additions & 5 deletions TestTargetFramework.props
Original file line number Diff line number Diff line change
Expand Up @@ -63,13 +63,11 @@
<IsTestProject>true</IsTestProject>
</PropertyGroup>

<PropertyGroup Label="net5.0 Warnings to be Disabled in Test Projects" Condition=" '$(TargetFramework)' == 'net5.0' ">
<!-- We purposely test on EoL frameworks for testing netstandard2.1, but we want to keep this warning in production code. -->
<CheckEolTargetFramework>false</CheckEolTargetFramework>
</PropertyGroup>

<PropertyGroup Label="Warnings to be Disabled in Test Projects">

<!-- We purposely test on EoL frameworks for testing netstandard2.1, but we want to keep this warning in production code. -->
<CheckEolTargetFramework Condition=" '$(TargetFramework)' == 'net5.0' ">false</CheckEolTargetFramework>

<NoWarn Label="Nested types should not be visible">$(NoWarn);CA1034</NoWarn>
<NoWarn Label="Use Literals Where Appropriate">$(NoWarn);CA1802</NoWarn>
<NoWarn Label="Do not ignore method results">$(NoWarn);CA1806</NoWarn>
Expand Down

0 comments on commit 51eb651

Please sign in to comment.