[pkg/translator/jaeger] Preserve binary attribute values #32208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
@open-telemetry/collector-contrib-approvers what's blocking this PR? |
crobert-1
approved these changes
Apr 22, 2024
|
@codeboten can we merge this? |
|
This is still awaiting a review from codeowner. cc @frzifus |
frzifus
approved these changes
Apr 23, 2024
bryan-aguilar
approved these changes
Apr 23, 2024
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…try#32208) **Description:** translate binary attribute values to/from Jaeger as is, without encoding them as base64 strings **Link to tracking Issue:** Resolves open-telemetry#32204 **Testing:** unit tests in the package **Documentation:** none --------- Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: translate binary attribute values to/from Jaeger as is, without encoding them as base64 strings
Link to tracking Issue: Resolves #32204
Testing: unit tests in the package
Documentation: none