Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Templates for issues/pull tracker #99

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

rpotter12
Copy link
Member

fixes #93

@rpotter12
Copy link
Member Author

@nntoan @Kreyren Please review this PR

@Kreyren
Copy link
Contributor

Kreyren commented Aug 18, 2019

@rpotter12

QA: Do not merge from master to avoid conflicting commits

image

@Kreyren
Copy link
Contributor

Kreyren commented Aug 18, 2019

@Kreyren Kreyren changed the title adding pull reuest and issue templates adding pull request and issue templates Aug 18, 2019
@Kreyren
Copy link
Contributor

Kreyren commented Aug 18, 2019

Relevant: there is also a gui for this https://help.github.com/en/articles/creating-issue-templates-for-your-repository

@Kreyren
Copy link
Contributor

Kreyren commented Aug 18, 2019

2009162

Moved in docs, because i believe it's better to organize these documents to be accesible by the community.

@@ -1,5 +1,7 @@
---
name: Bug report
labels: bug-report "P3 - Normal"
assignees: kreyren nntoan
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added labels and default assignees

@@ -1,4 +1,5 @@
---
title: "BUG: "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forcing BUG: prefix for bug format

name: Bug report
about: Create a report to help us improve

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added additional space since name and about are displayed in gui where title, labels etc are in issue

@@ -9,10 +9,6 @@ assignees: kreyren nntoan

---

**I'm submitting a ...** (check one with "x")
- [x] bug report
- [ ] feature request
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous changes should make this format obsolete since we are using labels and BUG: prefix

@@ -20,7 +20,7 @@ assignees: kreyren nntoan


### Steps to reproduce it
<!-- Add steps to reproduce bugs or add information on the place where the feature should be implemented. Add links to a sample deployment or code. -->
<!-- Add steps to reproduce provided bug, BE VERBOSE! -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forcing verbose since users are usually very strait forward and forget to provide important informations.

TODO? : Asking to make short, but verbose?

**I'm submitting a ...** (check one with "x")
- [ ] bug report
- [x] feature request
### Description/Abstract
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reworked feature request because i think that this is more effective

@Kreyren
Copy link
Contributor

Kreyren commented Aug 18, 2019

Review from @nntoan @rpotter12 is requested

@Kreyren Kreyren self-assigned this Aug 18, 2019
@Kreyren Kreyren changed the title adding pull request and issue templates docs: Templates for issues/pull tracker Aug 18, 2019
@rpotter12
Copy link
Member Author

@Kreyren I like this template too 👍

@Kreyren
Copy link
Contributor

Kreyren commented Aug 18, 2019

Disclaimer: i don't want to touch merge requests since these will be overwritten by git -> use your best judgement for these that are merging using GUI

@rpotter12
Copy link
Member Author

@nntoan Please review this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement P3 - Normal Priority 3 - Normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REQUEST: Issue and pull request templates
2 participants