feat: automatically include env variables starting with NUXT_ENV_ #3862
Conversation
|
@pi0 That's why I haven't ticked the box yet :P |
lib/common/options.js
Outdated
| @@ -161,6 +161,10 @@ Options.from = function (_options) { | |||
| vueConfig.performance = options.dev | |||
| } | |||
|
|
|||
| // merge custom env with variables | |||
| const eligibleEnvVariables = _.pick(process.env, Object.keys(process.env).filter(k => k.startsWith('NUXT_ENV_'))) | |||
| options.env = Object.assign(eligibleEnvVariables, options.env) | |||
There was a problem hiding this comment.
Shouldn't env variables override options.env? Maybe it would be better to use Object.assign({}, options.env, eligibleEnvVariables)
There was a problem hiding this comment.
I wasn't certain which behavior would be more appropriate.
On the one hand, it feels like someone "automatically injected" should have an option to get overridden.
On the other hand, env variables are way more "closer" to the system...
There was a problem hiding this comment.
The last point would be consistency. I'll change it to the suggested value
Codecov Report
@@ Coverage Diff @@
## dev #3862 +/- ##
==========================================
+ Coverage 97.57% 97.57% +<.01%
==========================================
Files 18 18
Lines 1196 1198 +2
Branches 328 328
==========================================
+ Hits 1167 1169 +2
Misses 28 28
Partials 1 1
Continue to review full report at Codecov.
|
17b11e7
to
a5b026e
Compare
5e0d878
to
7921d17
Compare
7921d17
to
82f7eff
Compare
|
Love this PR :) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
If you don't want to add all
env variablesto yournuxt.config.jsyou now can prefix them withNUXT_ENV_to get them automatically included in theprocess.envobject.Example:
NUXT_ENV_TEST=awesome nuxt build && nuxt startprocess.env.NUXT_ENV_TEST //awesomeTypes of changes
Checklist: