Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace opencollective-cli with @nuxtjs/opencollective #3836

Merged
merged 1 commit into from
Sep 2, 2018

Conversation

manniL
Copy link
Member

@manniL manniL commented Sep 2, 2018

Resolves: #3404

@manniL manniL requested a review from clarkdo September 2, 2018 15:06
@codecov-io
Copy link

codecov-io commented Sep 2, 2018

Codecov Report

Merging #3836 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##             dev   #3836   +/-   ##
=====================================
  Coverage   97.8%   97.8%           
=====================================
  Files         18      18           
  Lines       1183    1183           
  Branches     325     325           
=====================================
  Hits        1157    1157           
  Misses        25      25           
  Partials       1       1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e8a515...520e7a7. Read the comment docs.

@Atinux Atinux merged commit 31ec2a2 into nuxt:dev Sep 2, 2018
@manniL manniL deleted the feat-new-opencollective branch September 2, 2018 15:25
@husayt
Copy link
Contributor

husayt commented Oct 11, 2018

Can we remove this dependency or somehow make it optional? As this nuxt/opencollective library is hitting internet on use it has been deemed as potentially dangerous and blacklisted by our corporate npm proxy. As it is quaranteed that is blocking nuxt npm install as well. I appreciate that idea is to create awareness about project, but maybe it is not really necessary to download stats. Just show the message. You can appreciate that libraries which are accessing third party servers are frown upon and absolutely no-no for corporate use. They are automatically blocked. Now even if you would remove that code from library nuxt/collective library I am not sure if that would unblock it, as it is already blacklisted.

This really doesn't help when we are trying to create awareness for nuxt and promote it for corporate use. I would say problems this creates far outweigh the benefits.

cc @Atinux

@manniL
Copy link
Member Author

manniL commented Oct 11, 2018

@husayt Wow! Haven't thought about such a situation myself. Could you please open up a bug report or feature request for that case (so it can be tracked and discussed better)?

@lock
Copy link

lock bot commented Nov 10, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 10, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

opencollective postinstall fails in docker 100% of the time
5 participants