Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: window nuxt build by using cross-spawn #3833

Merged
merged 2 commits into from
Sep 1, 2018
Merged

Conversation

aldarund
Copy link

@aldarund aldarund commented Sep 1, 2018

node spawnSync have issues on windows and building fails with it with ENOENT error

@pi0 pi0 requested a review from clarkdo September 1, 2018 20:26
Copy link
Member

@clarkdo clarkdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Sep 1, 2018

Codecov Report

Merging #3833 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3833   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files          18       18           
  Lines        1162     1162           
  Branches      317      317           
=======================================
  Hits         1137     1137           
  Misses         24       24           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ea579...bf8fbf9. Read the comment docs.

@clarkdo clarkdo merged commit 9a70280 into nuxt:dev Sep 1, 2018
@lock
Copy link

lock bot commented Oct 31, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants