feat(route-config): add support for props and alias #3818
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #3818 +/- ##
=======================================
Coverage 97.84% 97.84%
=======================================
Files 18 18
Lines 1162 1162
Branches 317 317
=======================================
Hits 1137 1137
Misses 24 24
Partials 1 1Continue to review full report at Codecov.
|
| @@ -11,6 +11,9 @@ import Router from 'vue-router' | |||
| res += (route.component) ? ',\n\t' + tab + 'component: ' + (splitChunks.pages ? route._name : `() => ${route._name}.default || ${route._name}`) : '' | |||
| res += (route.redirect) ? ',\n\t' + tab + 'redirect: ' + JSON.stringify(route.redirect) : '' | |||
| res += (route.meta) ? ',\n\t' + tab + 'meta: ' + JSON.stringify(route.meta) : '' | |||
| res += (typeof route.props !== 'undefined') ? ',\n\t' + tab + 'props: ' + (typeof route.props === 'function' ? serialize(route.props) : JSON.stringify(route.props)) : '' | |||
There was a problem hiding this comment.
For consistency, this may be simplified into (route.props)
There was a problem hiding this comment.
According to vue-router docs, props can have Boolean value, so we can't just check its falsy value
There was a problem hiding this comment.
@farnabaz Regardless, route.props != null is the canonical way of checking null/undefined values in javascript. According to clean-code rules, checking for positive instead of negative is considered slightly easier to read. Robert C. Martin
If doesn't appear to be anywhere where null is accepted instead of undefined, so the code should be:
res += route.props == null ? '' : ',\n\t' + tab + 'props: ' + (typeof route.props === 'function' ? serialize(route.props) : JSON.stringify(route.props))Right?
There was a problem hiding this comment.
@dotnetCarpenter You're right. I'll create a new pull request to cleanup my code.
Thank you very much for your comment :)
There was a problem hiding this comment.
I suggest adding a comment link to the API source for better maintenance: https://router.vuejs.org/api/#routes
|
We can add docs to api/extendRoutes section: https://github.com/nuxt/docs/blob/2.0/en/api/configuration-router.md#extendroutes |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Currently nuxtjs support some of
vue-routerroute configs and some use fill configs likealiasandpropsis missing