Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update nuxt-start dependencies dynamically #3816

Merged
merged 4 commits into from
Aug 30, 2018

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Aug 29, 2018

No description provided.

@clarkdo clarkdo requested a review from pi0 August 29, 2018 07:21
@clarkdo clarkdo requested a review from Atinux August 29, 2018 10:39
@pi0
Copy link
Member

pi0 commented Aug 29, 2018

Shouldn't we gitignore start/package.json now? Also why we need to do this?

@clarkdo
Copy link
Member Author

clarkdo commented Aug 29, 2018

Because I think we offen forgot to synchronize new versions to start when upgrade denpendencies

@pi0
Copy link
Member

pi0 commented Aug 29, 2018

But we always auto-update versions during nuxt-edge-start release. Don't we? Maintaining scripts/data/dependencies/start.json would be just as hard as the start/package.json. BTW it's OK with your changes :D

But now i think we have to at least gitignore this package.json file to prevent unwanted changes into it

@codecov-io
Copy link

codecov-io commented Aug 29, 2018

Codecov Report

Merging #3816 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3816   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files          18       18           
  Lines        1162     1162           
  Branches      317      317           
=======================================
  Hits         1137     1137           
  Misses         24       24           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb33e0...059c6df. Read the comment docs.

@pi0
Copy link
Member

pi0 commented Aug 30, 2018

@clarkdo Maybe we can gitignore start/package.json against accidental changes (Only allowed to locally modifiable)

@pi0 pi0 merged commit 4311aca into nuxt:dev Aug 30, 2018
@lock
Copy link

lock bot commented Oct 31, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018
@clarkdo clarkdo deleted the update-start-deps branch April 2, 2019 13:16
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants