Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade babel to 7.0.0 #3814

Merged
merged 1 commit into from
Aug 28, 2018
Merged

feat: upgrade babel to 7.0.0 #3814

merged 1 commit into from
Aug 28, 2018

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Aug 28, 2018

Removed @babel/plugin-external-helpers because rollup-plugin-babel will automatically deduplicate helpers and warn in https://github.com/rollup/rollup-plugin-babel/blob/master/src/index.js#L80

@clarkdo clarkdo requested a review from pi0 August 28, 2018 19:44
@codecov-io
Copy link

codecov-io commented Aug 28, 2018

Codecov Report

Merging #3814 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #3814   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files          18       18           
  Lines        1162     1162           
  Branches      317      317           
=======================================
  Hits         1137     1137           
  Misses         24       24           
  Partials        1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83d9dc4...4c23524. Read the comment docs.

@pi0
Copy link
Member

pi0 commented Aug 28, 2018

You are awesome bro @clarkdo <3

@clarkdo clarkdo merged commit 7e77c82 into nuxt:dev Aug 28, 2018
@lock
Copy link

lock bot commented Oct 31, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018
@clarkdo clarkdo deleted the babel7 branch April 2, 2019 13:04
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants