Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade eslint to 5.x #3494

Merged
merged 6 commits into from
Aug 31, 2018
Merged

feat: upgrade eslint to 5.x #3494

merged 6 commits into from
Aug 31, 2018

Conversation

clarkdo
Copy link
Member

@clarkdo clarkdo commented Jul 4, 2018 •
edited

@codecov-io
Copy link

codecov-io commented Jul 4, 2018 •
edited

Codecov Report

Merging #3494 into dev will decrease coverage by 36.61%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##              dev    #3494       +/-   ##
===========================================
- Coverage   98.24%   61.63%   -36.62%     
===========================================
  Files          18       18               
  Lines        1139     1139               
  Branches      306      306               
===========================================
- Hits         1119      702      -417     
- Misses         20      339      +319     
- Partials        0       98       +98
Impacted Files Coverage Δ
lib/core/middleware/error.js 0% <0%> (-97.57%) ⬇️
lib/core/middleware/nuxt.js 3.44% <0%> (-96.56%) ⬇️
lib/builder/generator.js 0% <0%> (-94.24%) ⬇️
lib/core/meta.js 14.63% <0%> (-82.93%) ⬇️
lib/common/nuxt.config.js 50% <0%> (-50%) ⬇️
lib/core/renderer.js 54.19% <0%> (-45.81%) ⬇️
lib/core/nuxt.js 64.36% <0%> (-32.19%) ⬇️
lib/builder/builder.js 76.59% <0%> (-21.28%) ⬇️
lib/common/utils.js 78.91% <0%> (-21.09%) ⬇️
lib/builder/webpack/base.js 86.27% <0%> (-11.77%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa09a20...aecd10d. Read the comment docs.

@clarkdo clarkdo mentioned this pull request Aug 10, 2018
Closed
@pi0 pi0 mentioned this pull request Aug 24, 2018
Merged
clarkdo pushed a commit that referenced this pull request Aug 24, 2018
@pi0 @clarkdo
chore: update dependencies (#3794)
f7ca6cd 
Remaining:

- For `css-loader`: #3741
- For `eslint`: #3494
- For `postcss`: #3679
@galvez galvez changed the title [WIP] feat: upgrade eslint to 5.x feat: upgrade eslint to 5.x Aug 25, 2018
@galvez galvez added the WIP label Aug 25, 2018
@manniL
Copy link
Member

manniL commented Aug 31, 2018

@clarkdo New standard version (as well as jsx and eslint) has been published (https://github.com/standard/eslint-plugin-standard/releases/tag/v4.0.0)

@clarkdo
Copy link
Member Author

clarkdo commented Aug 31, 2018

Thanks, will update it this evening.

@clarkdo clarkdo requested review from pi0 and Atinux August 31, 2018 20:15
@clarkdo clarkdo removed the WIP label Aug 31, 2018
@clarkdo clarkdo merged commit b11e9c0 into nuxt:dev Aug 31, 2018
@lock
Copy link

lock bot commented Oct 31, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2018
@clarkdo clarkdo deleted the eslint-5.x branch April 2, 2019 13:07
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pi0 pi0 Awaiting requested review from pi0

@Atinux Atinux Awaiting requested review from Atinux

Assignees

@clarkdo clarkdo

Labels
2.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@clarkdo @codecov-io @manniL @galvez @danielroe