Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix regression bug related to setContext() #1986

Merged
merged 1 commit into from
Oct 30, 2017

Conversation

dotneet
Copy link

@dotneet dotneet commented Oct 30, 2017

now context.params and others can not be accessed from asyncData().

@codecov-io
Copy link

codecov-io commented Oct 30, 2017

Codecov Report

Merging #1986 into dev will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              dev   #1986      +/-   ##
=========================================
- Coverage   96.61%   96.3%   -0.32%     
=========================================
  Files          14      14              
  Lines         946     946              
=========================================
- Hits          914     911       -3     
- Misses         32      35       +3
Impacted Files Coverage Δ
lib/core/nuxt.js 93.18% <0%> (-4.55%) ⬇️
lib/core/renderer.js 95.02% <0%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ece774...4b5a035. Read the comment docs.

@Atinux Atinux merged commit 8860cbd into nuxt:dev Oct 30, 2017
@Atinux
Copy link
Member

Atinux commented Oct 30, 2017

Nice catch @dotneet

Really appreciate your work :)

@lock
Copy link

lock bot commented Nov 1, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Nov 1, 2018
@danielroe danielroe added the 2.x label Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants