-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing relation when calculating total for cart, item.adjustments #1862
base: develop
Are you sure you want to change the base?
fix: missing relation when calculating total for cart, item.adjustments #1862
Conversation
|
@dwene - this doesn't seem to work when we include the adjustments in the service; can't seem to figure out exactly what it is that is causing this issue |
Hmmm, our issue was that free orders weren't skipping the payment process when completing the cart. When I added that line using the medusa extender, it solved our issue. What isn't working? |
Or are you just saying there's an issue with the unit tests? |
…a-curry/medusa into fix-cart-total-missing-adjustments
Aha, found the issue and fixed. |
You cant fetch a cart with |
At some point, it would be good to pick one pattern or another. Either update all the entites off |
This was incorrectly calculating item prices with discounts applied when creating order from cart.