chore(medusa): Crud service accept an entity name

medusajs · Aug 11, 2022 · 41b190e · 41b190e
1 parent 5df587a
commit 41b190e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/packages/medusa/src/interfaces/transaction-crud-service.ts b/packages/medusa/src/interfaces/transaction-crud-service.ts
@@ -24,6 +24,7 @@ export abstract class TransactionCrudService<
 > extends TransactionBaseService<TChild> {
   protected constructor(
     protected readonly __repo__: ObjectType<Repository<TEntity>>,
+    protected readonly __entityName__: string,
     container: unknown,
     config?: Record<string, unknown>
   ) {
@@ -65,14 +66,9 @@ export abstract class TransactionCrudService<
     const entity = await repo.findOne(query)
 
     if (!entity) {
-      const entityName = repo.metadata.targetName
-        .replace(/([A-Z])/g, " $1")
-        .replace(/^./, function (str) {
-          return str.toUpperCase()
-        })
       throw new MedusaError(
         MedusaError.Types.NOT_FOUND,
-        `${entityName} with ${id} was not found`
+        `${this.__entityName__} with ${id} was not found`
       )
     }
 

diff --git a/packages/medusa/src/services/cart.ts b/packages/medusa/src/services/cart.ts
@@ -148,7 +148,7 @@ export default class CartService extends TransactionCrudService<
     storeService,
   }: InjectedDependencies) {
     // eslint-disable-next-line prefer-rest-params
-    super(cartRepository, arguments[0])
+    super(cartRepository, "Cart", arguments[0])
 
     this.manager_ = manager
     this.shippingMethodRepository_ = shippingMethodRepository