Skip to content

Commit

Permalink
Removed Bluebird dependency from project
Browse files Browse the repository at this point in the history
refs TryGhost/Ghost#14882

- this dependency is no longer needed because we're removed all
  functions that were supplied from it
  • Loading branch information
daniellockyer committed Aug 31, 2023
1 parent 6886c5f commit e9afe88
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
"@tryghost/pretty-cli": "1.2.38",
"@tryghost/server": "0.1.36",
"@tryghost/zip": "1.1.37",
"bluebird": "3.7.2",
"chalk": "4.1.2",
"common-tags": "1.8.2",
"express": "4.18.2",
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1569,7 +1569,7 @@ bl@^4.0.3:
inherits "^2.0.4"
readable-stream "^3.4.0"

bluebird@3.7.2, bluebird@^3.5.3:
bluebird@^3.5.3:
version "3.7.2"
resolved "https://registry.yarnpkg.com/bluebird/-/bluebird-3.7.2.tgz#9f229c15be272454ffa973ace0dbee79a1b0c36f"
integrity sha512-XpNj6GDQzdfW+r2Wnn7xiSAd7TM3jzkxGXBGTtWKuSXv1xUV+azxAm8jdWZN06QTQk+2N2XB9jRDkvbmQmcRtg==
Expand Down

1 comment on commit e9afe88

@markstos
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that after this change that bluebird is still pulled indirectly because express-hbs also requires it. I submitted a pull request to resolve the issue for express-hbs. Once that's merged, the version should be bumped here to generate a new yarn.lock that's 💯 % free of the bluebird dep. 🚀

TryGhost/express-hbs#252

Please sign in to comment.