Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing {{t}} wrapping for some Portal pages. #17049

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cathysarisky
Copy link
Contributor

@cathysarisky cathysarisky commented Jun 17, 2023

Got some code for us? Awesome 🎊!

I added missing translation string wrapping for 'Choose', 'Continue', '/ month', and free trials.

  • [ X] There's a clear use-case for this code change, explained below
  • [ X] Commit message has a short title & references relevant issues
  • [ X] The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!


🤖 Generated by Copilot at a1517a6

This pull request adds localization support for the portal feature of the Ghost app. It uses the t function from the AppContext to wrap the text values that need to be translated in the portal UI components. It also adds empty strings for various portal labels to the locale files for different languages, enabling translators to provide the appropriate translations. Additionally, it adds some translated strings for the French locale file for the portal feature.

@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05 🎉

Comparison is base (9774dc7) 71.56% compared to head (a1517a6) 71.62%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17049      +/-   ##
==========================================
+ Coverage   71.56%   71.62%   +0.05%     
==========================================
  Files        1817     1817              
  Lines      115330   115330              
  Branches    17114    17137      +23     
==========================================
+ Hits        82541    82607      +66     
+ Misses      31675    31604      -71     
- Partials     1114     1119       +5     
Flag Coverage Δ
e2e-tests 66.58% <ø> (+<0.01%) ⬆️
unit-tests 63.49% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant