[FIX] #has helper in case of integer values working fixed! closes - #16262 #16764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes - TryGhost#16262 Why - _isEmpty which was earlier using only checks object, array or string not integer so I've added an extra check if its integer handle it differently
1 task
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #16764 +/- ##
===========================================
+ Coverage 72.26% 84.69% +12.43%
===========================================
Files 1785 692 -1093
Lines 113257 53522 -59735
Branches 16928 6859 -10069
===========================================
- Hits 81847 45333 -36514
+ Misses 30306 8118 -22188
+ Partials 1104 71 -1033
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@daniellockyer have you got chance to review this? |
|
@daniellockyer Any update on this one? Can we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes - #16262
Why - _isEmpty which was earlier using only checks object, array or string not integer so I've added an extra check if its integer handle it differently
Got some code for us? Awesome 🎊!
Please include a description of your change & check your PR against this list, thanks!
yarn test:allandyarn lint)