Added member labels to template options #15430
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no issue Being able to access a member's label from the theme template allows customizing the content based on the type of member.
|
Thanks for this PR - I totally agree with this change in principle. However, this change is ringing an alarm bell for me because it touches the one place in the code where the theme API isn't directly pulling from the Content API and we haven't got any clear pattern or defined rules here - as you can see it's just a random made up JS object 😬 I'm slightly concerned about expanding it to include more stuff, when it's not clear what it is and whether it should be public info. Lemme have a little think on this and a chat with the engineers who know the code best, and figure if this is is defo safe to expose. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Being able to access a member's labels from the theme template allows customizing the user experience based on the type of member.
Trivial example:
I think there are many potential use cases that would be enabled by allowing labels to be used like this. For example, you could build a simple tier-like system (separate to the existing Stripe tier system) that hides certain post's content based on a member's tier label.
If we're happy exposing labels to theme templates, a useful next step could be adding label support to the
hashandlebars helper to make it easier to query whether or not a member has a given label.