Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tools/circle_plus_gen] Add tparam inject feature #13027

Merged
merged 2 commits into from
May 29, 2024

Conversation

zetwhite
Copy link
Contributor

@zetwhite zetwhite commented May 20, 2024

This PR adds a feature

  • inject training parameters to a circle plus instance.
  • export circle plus instance as a *.circle file

ONE-DCO-1.0-Signed-off-by: seunghui youn sseung.youn@samsung.com

@zetwhite zetwhite changed the title 0520/inject circle [tools/circle_plus_gen] Add tparam inject feature May 20, 2024
@zetwhite

This comment was marked as resolved.

@zetwhite zetwhite added the PR/NO MERGE Please don't merge. I'm still working on this :) label May 20, 2024
@zetwhite zetwhite changed the title [tools/circle_plus_gen] Add tparam inject feature [tools/circle_plus_gen] Add training parameters inject feature May 20, 2024
@zetwhite zetwhite closed this May 27, 2024
@zetwhite zetwhite reopened this May 27, 2024
@zetwhite zetwhite changed the title [tools/circle_plus_gen] Add training parameters inject feature [tools/circle_plus_gen] Add tparam inject feature May 27, 2024
@zetwhite zetwhite marked this pull request as ready for review May 27, 2024 05:43
@zetwhite zetwhite added PR/ready for review It is ready to review. Please review it. approval: 2 Require at least 2 approvals and removed PR/NO MERGE Please don't merge. I'm still working on this :) labels May 27, 2024
@zetwhite zetwhite requested a review from a team May 27, 2024 05:44
This PR adds a feature
 - inject training parameters to a circle plus instance
 - export circle plus instance as a *.circle file

ONE-DCO-1.0-Signed-off-by: seunghui youn <sseung.youn@samsung.com>

* related issue : Samsung#12650
hseok-oh
hseok-oh previously approved these changes May 28, 2024
Copy link
Contributor

@hseok-oh hseok-oh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh requested a review from a team May 28, 2024 01:35
Co-authored-by: Jiyoung Giuliana Yun <wldudyun10@gmail.com>
@@ -7,6 +8,7 @@

class TrainParam():
'''Wrapper class of circle_traninfo_generated.ModelTrainingT'''
TRAINING_PARAM_IDENTIFIER = b"CTR0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(note)

// file_identifier for circle training.
// The last character is a number which corresponds to the major version.
// This identifier number should be same if it does not break compatibility.
file_identifier "CTR0";

Copy link
Contributor

@jyoungyun jyoungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh hseok-oh merged commit db6b5af into Samsung:master May 29, 2024
3 checks passed
Torrero pushed a commit to Torrero/ONE_PUBLIC that referenced this pull request May 29, 2024
This PR adds a feature
 - inject training parameters to a circle plus instance
 - export circle plus instance as a *.circle file

ONE-DCO-1.0-Signed-off-by: seunghui youn <sseung.youn@samsung.com>
Co-authored-by: Jiyoung Giuliana Yun <wldudyun10@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: 2 Require at least 2 approvals PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants