Optional adding of two/three-letter language codes to names of downloaded subtitle files (#72, #108) #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krzemin zerknij w MR |
5fc6b0a
to
54754a2
Compare
Module for changing file paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related feature requests: #72, #108
Current implementation adds new option into the settings windows - "Add language code to subtitle file name". There are three choices:
If user selects "Two-letter" or "Three-letter" then every time subtitles are downloaded, appropriate language code will be added to the name of subtitles file e.g. if "Three-letter" is selected and user downloads polish SRT subtitles for "movie.mkv" video file, the name of subtitles file will be "movie.pol.srt".
Also when batch-downloading subtitles ("Scan directories" window), if "skip video files which already have subtitles" option is selected, subtitles with language codes in file names will be recognized too.
The "Add language code to subtitle file name" option is common for both languages - the primary and the secondary. Some suggested that it could be separate, but I think there is no point in doing so. Balance between functionality and simplicity must be kept.
Similarly the "skip video files which already have subtitles" option don't care about the language of existing subtitles. The option could have more variants i.e. "skip only if the language is unspecified (no language code in file name) or primary". But again, less is better in this case IMO.
Let know what you think.