Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for install-powershell.sh and amazon linux #9314

Merged
merged 8 commits into from
Apr 8, 2019

Conversation

TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Apr 7, 2019

PR Summary

Add CI for install-powershell.sh and amazon linux

PR Context

see #9285

Also, just making sure we can run CI jobs using our containers.

PR Checklist

@PoshChan

This comment has been minimized.

@TravisEz13 TravisEz13 force-pushed the add_amazonlinux branch 3 times, most recently from c2c30c8 to fcee2df Compare April 7, 2019 18:32
@TravisEz13 TravisEz13 marked this pull request as ready for review April 7, 2019 18:41
@TravisEz13 TravisEz13 changed the title Add amazonlinux Add CI for install-powershell.sh and amazon linux Apr 7, 2019
@@ -15,6 +15,7 @@ trigger:
- /tools/installpsh-redhat.sh
- /tools/installpsh-suse.sh
- /tools/install-powershell.ps1
- /.vsts-ci/install-ps.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a circular reference. Why should this file include itself?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, it's just saying run this if this file changes.

jobName: InstallPowerShellUbuntu
pool: Hosted Ubuntu 1604
verification: |
$PSVersionTable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Convert to version and throw if not less than 6.2.0

@TravisEz13 TravisEz13 merged commit b990c76 into PowerShell:master Apr 8, 2019
@TravisEz13 TravisEz13 deleted the add_amazonlinux branch April 8, 2019 22:42
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Apr 11, 2019
@TravisEz13 TravisEz13 added this to the 7.0.0-preview.1 milestone Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants