Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish test and code coverage artifacts for daily builds #8955

Merged
merged 2 commits into from
Feb 25, 2019
Merged

Publish test and code coverage artifacts for daily builds #8955

merged 2 commits into from
Feb 25, 2019

Conversation

adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Feb 23, 2019 •
edited

PR Summary

Reenable publishing code coverage and test artifacts

PR Context

Refactoring AppVeyor.psm1 into ci.psm1 clobbered the change for publishing code coverage and test artifacts on Windows.

PR Checklist

@RDIL
Copy link
Contributor

RDIL commented Feb 25, 2019

@adityapatwardhan can you please add fixes #8930 to the body of the PR so it closes the issue? All looks good so far!

@adityapatwardhan
Copy link
Member Author

@RDIL it is related but does not completely fix #8930

@RDIL
Copy link
Contributor

RDIL commented Feb 25, 2019

Okay.

@adityapatwardhan adityapatwardhan marked this pull request as ready for review February 25, 2019 18:18
@adityapatwardhan adityapatwardhan merged commit 76e8091 into PowerShell:master Feb 25, 2019
@adityapatwardhan adityapatwardhan deleted the FixDailyTestPackageWindows branch February 25, 2019 21:03
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@anmenaga anmenaga Awaiting requested review from anmenaga anmenaga is a code owner

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw daxian-dbw is a code owner

@PaulHigin PaulHigin Awaiting requested review from PaulHigin

Assignees

@adityapatwardhan adityapatwardhan

Labels
CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adityapatwardhan @RDIL @TravisEz13