[ERNIEBot Researcher] update langchain #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
qingzhong1
commented
Jan 23, 2024
•
w5688414
reviewed
Jan 23, 2024
erniebot-agent/applications/erniebot_researcher/tools/semantic_citation_tool.py
Outdated
Show resolved
Hide resolved
erniebot-agent/applications/erniebot_researcher/tools/semantic_citation_tool.py
Outdated
Show resolved
Hide resolved
erniebot-agent/applications/erniebot_researcher/tools/preprocessing.py
Outdated
Show resolved
Hide resolved
w5688414
reviewed
Jan 23, 2024
w5688414
reviewed
Jan 23, 2024
| service_context = ServiceContext.from_defaults(embed_model=embeddings) | ||
| index = load_index_from_storage(storage_context=storage_context, service_context=service_context) | ||
| return index | ||
| if not abstract and not use_data: |
There was a problem hiding this comment.
use_data可以换个名字吗？我还是不是很理解这个字段能够直观表达的意思
There was a problem hiding this comment.
use_data是使用相关数据直接建库，不是像full text或者abstract利用path读取数据来建库
erniebot-agent/applications/erniebot_researcher/tools/preprocessing.py
Outdated
Show resolved
Hide resolved
erniebot-agent/applications/erniebot_researcher/tools/preprocessing.py
Outdated
Show resolved
Hide resolved
erniebot-agent/applications/erniebot_researcher/tools/preprocessing.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.